Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): adding icons for new home component #691

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat(icons): adding icons for new home component #691

merged 2 commits into from
Jan 27, 2025

Conversation

anabrook
Copy link
Contributor

@anabrook anabrook commented Jan 27, 2025 •
edited
Loading

What is being delivered?

Add icons:

  • bolt
  • format_paint
  • gavel
  • hardware
  • directions_car
  • handyman
  • park
  • plumbing

What impacts?

  • Icons

@anabrook anabrook self-assigned this Jan 27, 2025
@anabrook anabrook changed the title feat: adding icons for new home component feat(icons): adding icons for new home component Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-27 20:24 UTC

igorwessel
igorwessel requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@igorwessel igorwessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precisamos retirar o atributo fill para que o componente icon seja capaz de atribuir cores para esses ícones

@anabrook anabrook requested a review from igorwessel January 27, 2025 19:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'juntossomosmais_atomium_core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anabrook anabrook merged commit fffcf04 into main Jan 27, 2025
4 checks passed
@anabrook anabrook deleted the feat/add-icons-new-component-in-home branch January 27, 2025 20:22
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorwessel igorwessel igorwessel approved these changes

@gabrielduete gabrielduete gabrielduete approved these changes

@felipefialho felipefialho Awaiting requested review from felipefialho

Assignees

@anabrook anabrook

Labels
package/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anabrook @igorwessel @gabrielduete