Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): adjust name component rich tooltip to popover #708

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

gabrielduete
Copy link
Contributor

@gabrielduete gabrielduete commented Feb 20, 2025

Infos

Task

What is being delivered?

This pull request includes changes to rename the AtomRichTooltip component to AtomPopover across various files. The changes involve updating the component's name, its import paths, and related documentation.

Key changes include:

Component Renaming:

  • Renamed the AtomRichTooltip component to AtomPopover in the implementation file packages/core/src/components/rich-tooltip/popover.tsx [1] [2].

Test File Updates:

  • Updated the test file to reflect the new component name and file path (packages/core/src/components/rich-tooltip/popover.spec.ts) [1] [2].

Storybook Documentation:

  • Renamed the Storybook args and component references from RichTooltip to Popover in packages/core/src/components/rich-tooltip/stories/popover.args.ts [1] [2] [3] [4] [5].
  • Updated Storybook core stories to use Popover instead of RichTooltip (packages/core/src/components/rich-tooltip/stories/popover.core.stories.tsx) [1] [2].
  • Updated Storybook React stories to use Popover instead of RichTooltip (packages/core/src/components/rich-tooltip/stories/popover.react.stories.tsx) [1] [2] [3].
  • Updated Storybook Vue stories to use Popover instead of RichTooltip (packages/core/src/components/rich-tooltip/stories/popover.vue.stories.tsx) [1] [2] [3].

What impacts?

Component popover

Reversal plan

Revert this PR (#708)

Evidences

image

image

Copy link
Contributor

github-actions bot commented Feb 20, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-20 17:21 UTC

@gabrielduete gabrielduete marked this pull request as ready for review February 20, 2025 14:10
Copy link

@gabrielduete gabrielduete changed the title feat(popover): adjust name component fix(popover): adjust name component rich tooltip to popover Feb 20, 2025
@gabrielduete gabrielduete requested review from a team, dyhalmeida, mauriciomutte, 3rdepaula and jowjow22 and removed request for a team February 20, 2025 14:42
Copy link
Contributor

@felipefialho felipefialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! 🚀

@gabrielduete gabrielduete merged commit 1460bd8 into main Feb 20, 2025
5 checks passed
@gabrielduete gabrielduete deleted the feat/adjust-name-component-popover branch February 20, 2025 17:19
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants