Run cells with specific language#892
Open
shay1bz wants to merge 4 commits into
Open
Conversation
Author
|
@devstein would you mind taking a look at this? |
Collaborator
|
Hey @shay1bz 👋 sorry for the late response. Are you still opening to contributing? I can help with testing. We'll also want to add an example notebook |
Author
|
Hi @devstein . Yes, I’d be happy to move this PR forward. We've been using it in my organization for a while, and it’s proven to be very useful. |
Collaborator
|
@shay1bz Amazing 🙌 Let me know how I can help |
Author
|
@devstein I can provide the example notebook, but I'll need some assistance with writing the unit tests. From my perspective, we mainly need to verify that the language parameter, when specified, is correctly passed to the Livy HTTP request. |
Author
|
Hi @devstein, I have added an example notebook. How can we move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses the same functionality as #598 but with some differences, this PR is for allowing users to execute cells with specific languages against the same Spark Session. Given that #598 is nearly 5 years old and seems abandoned, this implementation provides a minimal, backward-compatible solution.
Due to a lack of familiarity with the sparkmagic code base, no tests have been added. I kindly request guidance on how to implement unit tests.
The changes have been manually tested on a notebook, ensuring compatibility with shared DataFrames and UDFs between Scala and Python.
Checklist
blackCHANGELOG.mdfileREADME.mdfile