You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @jeffeth-donaldson thanks for opening a PR! Do you know why this code causes duplicate fields? How can we support older version of Jupyter as well?
Apologies, @devstein, I'm not terribly familiar with IPywidgets.
I believe the issue is that _repr_html_ is supposed to return an html string whereas here display was called which actually draws the widget to the screen.
I'm guessing in newer versions of Jupyter, the display method gets called recursively on the children already which is why the duplication occurs. I can see if returning all the children's html as a string works on older versions of Jupyter, however, I no longer require sparkmagic so I'm not sure how quickly I'll get around to it. I also do not know what version of Jupyter introduced this issue, so I'd have to figure that out for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kind:bugAn unexpected error or issue with sparkmagicsize:XSThis PR changes 0-9 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the fields are duplicated on newer versions of jupyter.
Checklist
blackCHANGELOG.mdfileIf adding a feature, there is an example notebook and/or documentation in theREADME.mdfile