Skip to content

Conversation

@minrk
Copy link
Contributor

@minrk minrk commented Jun 16, 2022

to avoid calls to deprecated make_current

closes #876

@minrk minrk force-pushed the tornasync-ioloop branch from d0c06c5 to b53384c Compare June 16, 2022 14:28
to avoid calls to deprecated make_current
@minrk minrk force-pushed the tornasync-ioloop branch from b53384c to 9e06759 Compare June 16, 2022 14:29
@minrk
Copy link
Contributor Author

minrk commented Jun 16, 2022

If there's a failure (likely a hang) it means something else is accessing the loop via IOLoop.current() or asyncio.get_event_loop() while it's not running. That ought to trigger a deprecation warning, though.

@minrk minrk marked this pull request as draft June 16, 2022 14:35
@minrk
Copy link
Contributor Author

minrk commented Jun 16, 2022

This is not at all pressing, since it's just avoiding a deprecated API that is still fully supported.

@blink1073
Copy link
Contributor

Superseded by #1035

@blink1073 blink1073 closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pytest-Tornasync triggering Deprecation Warnings with Tornado 6.2

2 participants