Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kernel.json into examples #18

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Move kernel.json into examples #18

merged 3 commits into from
Jul 2, 2024

Conversation

anutosh491
Copy link
Contributor

No description provided.

@anutosh491 anutosh491 changed the title Changed in CMakeLists.txt to generate kernel json Changes in CMakeLists.txt to generate kernel json Jun 21, 2024
JohanMabille
JohanMabille reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually xeus-qt is NOT a kernel, but a server implementation based on Qt. Therefore this kernelspec should live in the example folder.

@anutosh491 anutosh491 changed the title Changes in CMakeLists.txt to generate kernel json Move kernel.json into examples Jun 21, 2024
@anutosh491 anutosh491 requested a review from JohanMabille June 21, 2024 08:31
@JohanMabille JohanMabille merged commit 67a82db into jupyter-xeus:main Jul 2, 2024
6 checks passed
@anutosh491 anutosh491 deleted the kerneljson branch July 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anutosh491 @JohanMabille