CI fix for "Testing nbclassic" on macos 3.7, 3.8, 3.9, 3.10 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnekbytes
changed the title
ericsnekbytes
force-pushed
the
ci_fix_macos_build
branch
from
a6c90d3 to
a9bbae6
Compare
echarles
approved these changes
May 31, 2022
There was a problem hiding this comment.
@ericsnekbytes LGTM. I will merge. Congratulations for your first merged PR on nbclassic 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the github actions for running pytest commands from "pytest foo" to "python -m pytest foo". Both usages are roughly equivalent, see this page for more info about the difference. These tests now succeed:
Where previously they were failing (see here for reference to the failing tests addressed by this PR).