Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream CI Job #110

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Conversation

echarles
Copy link
Member

@echarles echarles commented Jun 3, 2022

Attempt to fix the downstream CI job.

@echarles echarles added the bug Something isn't working label Jun 3, 2022
@echarles
Copy link
Member Author

echarles commented Jun 3, 2022

@blink1073 I have disable the jupyterlab_server downstream test which was giving error when running. pytest --pyargs jupyterlab_server

  256     Get all jupyterlab extensions installed that contain locale data.
  257 
  258     Returns
  259     -------
  260     tuple
  261         A tuple in the form `(locale_data_dict, message)`,
  262         where the `locale_data_dict` is an ordered list
  263         of available language packs:
  264             >>> {"package-name": locale_data, ...}
  UNEXPECTED EXCEPTION: SyntaxError('invalid syntax', ('<doctest jupyterlab_server.translation_utils.get_installed_packages_locale[0]>', 1, 34, '{"package-name": locale_data, ...}\n'))
  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/doctest.py", line 1334, in __run
      exec(compile(example.source, filename, "single",
    File "<doctest jupyterlab_server.translation_utils.get_installed_packages_locale[0]>", line 1
      {"package-name": locale_data, ...}

The jupyterlab downstream test works fine.

Any idea how to fix this? Should we temporary disable the jupyterlab_server test for now?

@blink1073
Copy link
Contributor

We're using it fine in jupyter_server, perhaps copy that block.

@echarles echarles marked this pull request as ready for review June 3, 2022 13:37
@echarles
Copy link
Member Author

echarles commented Jun 3, 2022

We're using it fine in jupyter_server, perhaps copy that block.

@blink1073 All good now. Thx again for the friendly hands. I have undrafted this PR and it is ready to be merged.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@echarles echarles merged commit a05d4d4 into jupyter:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants