-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shim to support the notebook extensions #113
Shim to support the notebook extensions #113
Conversation
For classic extensions to be operational, we may also need jupyter-server/jupyter_server#868 (add back IPythonHandler) and depend on a new jupyter-server release with that patch. |
We have discussed this PR and the options to ensure backwards compatibility of the notebook extensions for nbclassic at last community call with @Zsailer and @afshin . I have further discussed the options with @ericsnekbytes , @RRosio and @seibert. My last commit takes into account the feedback to not add IPythonHandler into jupyter-server. There are advantages to progress with the option of this PR to:
I will demo this PR at today community call with various setups (nbclassic with a working notebook extension while notebook 7, or notebook 7 or no notebook is installed). cc/ @kevingoldsmith |
@Zsailer We have just discussed the options at the community call and would love you feedback on the option proposed in this PR. I have given the demo and will be happy to replay it in one-one if you like. We have decided to re-discuss this during next week community call. Of course, we don't need to wait that call to further brainstorm and exchange on this 👍 |
👍 Totally agree with these two goals. I think this approach is good. Let's roll with it. If we hear reports of major issues coming from patching Great work, @echarles! |
Super! Thx a log @Zsailer for the review and though with this. I see relevant CI failure due to the usage of |
The failing selenium tests are also encountered in #114. This is prolly a regression and not related to this PR. I have fixed the relevant tests, so this is good to go. Merging. |
I have opened #114 to follow-up on the selenium tests. |
This PR add a shim to ensure the classic notebook extension installed on top of nbclassic do not break while importing notebook packages being no more available in nbclassic. To achieve this backwards compatibility, the needed module/package are shimmed, based on the existence or not of specific versions of notebook (V6, >V7).