Handle execution errors with empty traceback entries similar to Lab #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarles
approved these changes
Jul 9, 2022
There was a problem hiding this comment.
LGTM Thx @kevin-bates The Selenium failures are expected in the current main branch (state 1 failed, 30 passed) and is not related to these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of jupyter/notebook#6466 to
nbclassicdue to release management timelines. Please refer to that PR for details and screenshots. In a nutshell, this pull request makes the rendering of errors returned from execution requests like that of Jupyter Lab such that error payloads with empty tracebacks, but non-empty error name and value entries, will display the error.