Skip to content

replace check_pid and variants with psutil library #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mueslo
Copy link
Contributor

@mueslo mueslo commented Oct 2, 2020

Improvements:

  • a lot more tested and resilient (e.g. _check_pid_win32 has bugs)
  • ensures not just that nbserver has the same PID but also was created at the same time (PID may be reused)

Drawback:

  • adds a new dependency

also write creation time of process into nbserver json file to make sure it is the same process
@mueslo mueslo mentioned this pull request Oct 2, 2020
@mueslo mueslo marked this pull request as ready for review October 5, 2020 11:24
@kevin-bates
Copy link
Member

Hi @mueslo - thank you for all the work on this and #5789. I believe the latter is sufficient. This approach changes the server-info structure (which I'm not sure will have side-affects) and introduces another package. Given you've found closing the handle resolves the known issue, let's stick with that for now. Thank you.

I'm going ahead with this closure. Should we find something more than closing the handle we can reopen at that time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants