Skip to content

Comments

nudge both the shell and control channels#6290

Merged
blink1073 merged 1 commit intojupyter:masterfrom
kycutler:kycutler/nudgedebugfix
Feb 28, 2022
Merged

nudge both the shell and control channels#6290
blink1073 merged 1 commit intojupyter:masterfrom
kycutler:kycutler/nudgedebugfix

Conversation

@kycutler
Copy link
Contributor

@blink1073 blink1073 added the bug label Feb 28, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kycutler
Copy link
Contributor Author

Thanks for the review @blink1073! Is there anything else or can this be merged?

@blink1073
Copy link
Contributor

Test failures are unrelated, we can merge this one.

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/notebook-v6-bugfix-release/13310/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port bugfix from jupyter_server

3 participants