Skip to content

Patch handling of singleClickNavigation #7627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .yarn/patches/@jupyterlab-filebrowser-npm-4.4.0-0616cbcbf2.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
diff --git a/lib/listing.js b/lib/listing.js
index 07b699656bf1780aada21fb50c3c7748086e20e5..42c34c27f8c88993210ef1ce422a05967c2e5aeb 100644
--- a/lib/listing.js
+++ b/lib/listing.js
@@ -1162,6 +1162,9 @@ export class DirListing extends Widget {
// previously focussed item will be focussed.
this._focusItem(this._focusIndex);
}
+ if (this._allowSingleClick) {
+ this.evtDblClick(event);
+ }
}
/**
* Handle the `'scroll'` event for the widget.
@@ -1241,9 +1244,6 @@ export class DirListing extends Widget {
document.addEventListener('mouseup', this, true);
document.addEventListener('mousemove', this, true);
}
- if (this._allowSingleClick) {
- this.evtDblClick(event);
- }
}
/**
* Handle the `'mouseup'` event for the widget.
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
"resolutions": {
"@types/react": "^18.0.26",
"react": "^18.2.0",
"yjs": "^13.5.40"
"yjs": "^13.5.40",
"@jupyterlab/filebrowser@~4.4.0": "patch:@jupyterlab/filebrowser@npm%3A4.4.0#./.yarn/patches/@jupyterlab-filebrowser-npm-4.4.0-0616cbcbf2.patch",
"@jupyterlab/filebrowser@^4.4.0": "patch:@jupyterlab/filebrowser@npm%3A4.4.0#./.yarn/patches/@jupyterlab-filebrowser-npm-4.4.0-0616cbcbf2.patch"
},
"devDependencies": {
"@jupyterlab/buildutils": "~4.4.0",
Expand Down
30 changes: 29 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3298,7 +3298,7 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlab/filebrowser@npm:^4.4.0, @jupyterlab/filebrowser@npm:~4.4.0":
"@jupyterlab/filebrowser@npm:4.4.0":
version: 4.4.0
resolution: "@jupyterlab/filebrowser@npm:4.4.0"
dependencies:
Expand Down Expand Up @@ -3326,6 +3326,34 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlab/filebrowser@patch:@jupyterlab/filebrowser@npm%3A4.4.0#./.yarn/patches/@jupyterlab-filebrowser-npm-4.4.0-0616cbcbf2.patch::locator=%40jupyter-notebook%2Froot%40workspace%3A.":
version: 4.4.0
resolution: "@jupyterlab/filebrowser@patch:@jupyterlab/filebrowser@npm%3A4.4.0#./.yarn/patches/@jupyterlab-filebrowser-npm-4.4.0-0616cbcbf2.patch::version=4.4.0&hash=7a0108&locator=%40jupyter-notebook%2Froot%40workspace%3A."
dependencies:
"@jupyterlab/apputils": ^4.5.0
"@jupyterlab/coreutils": ^6.4.0
"@jupyterlab/docmanager": ^4.4.0
"@jupyterlab/docregistry": ^4.4.0
"@jupyterlab/services": ^7.4.0
"@jupyterlab/statedb": ^4.4.0
"@jupyterlab/statusbar": ^4.4.0
"@jupyterlab/translation": ^4.4.0
"@jupyterlab/ui-components": ^4.4.0
"@lumino/algorithm": ^2.0.3
"@lumino/coreutils": ^2.2.1
"@lumino/disposable": ^2.1.4
"@lumino/domutils": ^2.0.3
"@lumino/dragdrop": ^2.1.6
"@lumino/messaging": ^2.0.3
"@lumino/polling": ^2.1.4
"@lumino/signaling": ^2.1.4
"@lumino/virtualdom": ^2.0.3
"@lumino/widgets": ^2.7.0
react: ^18.2.0
checksum: e69aca6f103e00189ca3b138faef3b0e9d638e646e4e5ea65178e4f50a6c5972fd88c7f8b57b9202a9ba922baef41f1b258540b9b26e05b4ffda3eba39fc98fa
languageName: node
linkType: hard

"@jupyterlab/fileeditor-extension@npm:~4.4.0":
version: 4.4.0
resolution: "@jupyterlab/fileeditor-extension@npm:4.4.0"
Expand Down
Loading