Start Y Websocket Server earlier and make it resilient to crashes#294
Closed
Zsailer wants to merge 1 commit intojupyterlab:mainfrom
Closed
Start Y Websocket Server earlier and make it resilient to crashes#294Zsailer wants to merge 1 commit intojupyterlab:mainfrom
Zsailer wants to merge 1 commit intojupyterlab:mainfrom
Conversation
Contributor
davidbrochart
requested changes
Apr 25, 2024
Collaborator
davidbrochart
left a comment
There was a problem hiding this comment.
Thanks @Zsailer.
I think that it would be better to have an auto_restart parameter passed to pycrdt-websocket's WebsocketServer, that would essentially do the same as here (restart on exception). That way, it would benefit to all users of the WebSocket server, not just jupyter-collaboration. What do you think?
I can open a PR there if you want.
Member
Author
Sure! That sounds great. I'm happy to make the PR over there as well. Just let me know. |
Collaborator
|
I opened y-crdt/pycrdt-websocket#31. |
af4431a to
a893b45
Compare
Member
Author
|
This depends on a release of pycrdt-websocket (hence why the tests are failing). |
Member
Author
|
Closing in favor of #295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the server locking we see in #290
This PR makes two critical changes:
This depends on this PR in Jupyter Server: jupyter-server/jupyter_server#1417