Cloning from new host via ssh causes spurious error rather than prompting for confirmation and succeeding #1408
Conversation
…ting for confirmation and succeeding
|
|
|
Just a suggestion in search of broader consensus, I don't insist on this change be made right away: The message popup does not say exactly what will be added to my Other than that, I like this, it will be nice to have. |
jupyterlab_git/ssh.py
Outdated
| """ | ||
| Check if the given git clone URL contains a known host | ||
| """ | ||
| cmd = ["ssh-keygen", "-F", hostname.replace(" ", "")] |
There was a problem hiding this comment.
Is this for spaces at the beginning and end only? If so, why not .strip()?
There was a problem hiding this comment.
Thanks for the suggestion, changed to .strip()
| A class to perform ssh actions | ||
| """ | ||
|
|
||
| def is_known_host(self, hostname): |
There was a problem hiding this comment.
Can this be implemented in a "ask for forgiveness, not for permission" manner? That is, run clone, and if it fails on host not known, prompt user to add host?
There was a problem hiding this comment.
That could be done as well, the issue for me doing this at first is to know if the error message remains consistent in all systems so I can check it on client then prompt user, hence I did added the check before attempting to clone. Should I go ahead and do the approach you suggested anyway?
There was a problem hiding this comment.
Don't know. It makes sense to me, don't know if it would make sense to the maintainers here.
Is it possible to somehow hook into the git/ssh/credential-helper stuff more tightly so that you aren't reduced to parsing user-facing messages on stdout to determine what's happening? If you'd have to do that, then current solution is way better.
There was a problem hiding this comment.
My reason for disliking the original implementation is that
The host is unknown, would you like to add it to the list of known hosts?
does not say what I'm actually adding to my known hosts by clicking the button. Also it does not reveal the file location being modified, which IMO there should be, somewhere, possibly in a smaller grayer font, like a postscript, something like that.
Also, I dislike that the fingerprint is examined twice, first during the initial check and then during actual connection attempt. I do not see how this could be turned into something like time-of-check/time-of-use vulnerability, maybe it cannot, but if there is another better way found, I would prefer that one.
There was a problem hiding this comment.
does not say what I'm actually adding to my known hosts by clicking the button. Also it does not reveal the file location being modified, which IMO there should be, somewhere, possibly in a smaller grayer font, like a postscript, something like that.
Thanks for the suggestion, changing the dialog body would require us to create a form for the dialog. Let me know if that way is a feasible one.Or I could also emit a notification after the host is added:
Also, I dislike that the fingerprint is examined twice, first during the initial check and then during actual connection attempt. I do not see how this could be turned into something like time-of-check/time-of-use vulnerability, maybe it cannot, but if there is another better way found, I would prefer that one.
I could simply check the known_hosts file and see if a fingerprint is present there for a given host, this was my first try, but I want to avoid referent to this file due possible Windows incompatible, but I ended having to refer to this file directly anyway :/ Let me know if you that's a better approach and we can switch to it. Thanks!
There was a problem hiding this comment.
The host %1 is not known
I love that, thanks!
This is a possible fix for #1342
When a host is unknown then user will be prompted to add it to the know hosts file:
If the users clicks OK then the hostname is checked and added to the known hosts and it is proceeded by the clone operation, otherwise the clone operation will proceed and will likely fail.
Please bear in mind that I didn't check this on Windows, but I am opening the PR anyway for discussion and getting reviews because this is my first contribution for this plugin, so I may be missing some important details.
Thanks!