-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ARM64 hosts #273
base: master
Are you sure you want to change the base?
Support ARM64 hosts #273
Conversation
513e2e3
to
ccf95d9
Compare
@@ -123,7 +128,7 @@ jobs: | |||
dir: ${{ matrix.dir }} | |||
modules: ${{ matrix.qt.modules }} | |||
version: ${{ matrix.qt.requested }} | |||
tools: tools_ifw tools_qtcreator,qt.tools.qtcreator | |||
tools: tools_ifw tools_qtcreator_gui,qt.tools.qtcreator_gui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name seems to have changed a while back; tools_qtcreator
doesn't exist for ARM64 Linux and references version 9.0 on other platforms. tools_qtcreator_gui
is for the latest version (15.0 at the moment).
Awesome work @jdpurcell ! |
This looks great any idea when we can use this for our arm actions ? @jdpurcell |
Fixes #248.
This PR is based on #268 hence the unrelated commits due to overlapping work inEDIT: Already changed base; unrelated commits have dropped off.requiresParallelDesktop
. Once the other is merged, we can get the unrelated commits to drop off and you'll only see the latest 2 commits here. (GitHub doesn't do this automatically upon merge, but it doesn't require a true rebase; simply click the Edit button next to the PR title, click thebase: master
dropdown, click themaster
branch, and clickChange base
). If you don't want to merge #268 first or at all, let me know and I can redo the work onmaster
.The Linux part is working fine, I already have my
kimageformats-binaries
andqView
forks using it and building a working aarch64 AppImage. I haven't tested the Windows part since the ARM64 Windows runners aren't public yet.