fix(pm_auth): Resolved comments

juspay · Feb 8, 2024 · 3b907ac · 3b907ac
1 parent 2f6f8ee
commit 3b907ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
@@ -2834,8 +2834,7 @@ async fn get_bank_account_connector_details(
 
                 let pm_type = pm
                     .payment_method_type
-                    .ok_or(errors::ApiErrorResponse::InternalServerError)
-                    .into_report()
+                    .get_required_value("payment_method_type")
                     .attach_printable("PaymentMethodType not found")?;
 
                 let token_data = BankAccountTokenData {

diff --git a/crates/router/src/core/pm_auth.rs b/crates/router/src/core/pm_auth.rs
@@ -711,7 +711,12 @@ pub async fn retrieve_payment_method_from_auth_service(
 
     let name = address
         .as_ref()
-        .and_then(|addr| addr.first_name.clone().map(|name| name.into_inner()));
+        .and_then(|addr| addr.first_name.clone().map(|name| name.into_inner()))
+        .ok_or(errors::ApiErrorResponse::GenericNotFoundError {
+            message: "billing_first_name not found".to_string(),
+        })
+        .into_report()
+        .attach_printable("billing_first_name not found")?;
 
     let address_details = address.clone().map(|addr| {
         let line1 = addr.line1.map(|line1| line1.into_inner());
@@ -742,7 +747,7 @@ pub async fn retrieve_payment_method_from_auth_service(
         .get_required_value("email")?;
 
     let billing_details = BankDebitBilling {
-        name: name.unwrap_or_default(),
+        name,
         email,
         address: address_details,
     };