fix: consider status of payment method before filtering wallets in li…

…st pm (#7007)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>

crates/api_models/src/admin.rs

@@ -1553,7 +1553,6 @@ pub struct MerchantConnectorUpdate {
 
 #[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
 #[serde(deny_unknown_fields)]
-
 pub struct ConnectorWalletDetails {
     /// This field contains the Apple Pay certificates and credentials for iOS and Web Apple Pay flow
     #[serde(skip_serializing_if = "Option::is_none")]

crates/api_models/src/analytics.rs

@@ -272,7 +272,6 @@ pub struct PaymentIntentFilterValue {
 
 #[derive(Debug, serde::Deserialize, serde::Serialize)]
 #[serde(rename_all = "camelCase")]
-
 pub struct GetRefundFilterRequest {
     pub time_range: TimeRange,
     #[serde(default)]
@@ -287,7 +286,6 @@ pub struct RefundFiltersResponse {
 
 #[derive(Debug, serde::Serialize, Eq, PartialEq)]
 #[serde(rename_all = "camelCase")]
-
 pub struct RefundFilterValue {
     pub dimension: RefundDimensions,
     pub values: Vec<String>,
@@ -413,7 +411,6 @@ pub struct DisputeFiltersResponse {
 
 #[derive(Debug, serde::Serialize, Eq, PartialEq)]
 #[serde(rename_all = "camelCase")]
-
 pub struct DisputeFilterValue {
     pub dimension: DisputeDimensions,
     pub values: Vec<String>,

crates/api_models/src/api_keys.rs

@@ -212,7 +212,7 @@ mod never {
     {
         struct NeverVisitor;
 
-        impl<'de> serde::de::Visitor<'de> for NeverVisitor {
+        impl serde::de::Visitor<'_> for NeverVisitor {
             type Value = ();
 
             fn expecting(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {

crates/api_models/src/enums.rs

@@ -141,7 +141,6 @@ pub enum FrmConnectors {
 )]
 #[serde(rename_all = "snake_case")]
 #[strum(serialize_all = "snake_case")]
-
 pub enum TaxConnectors {
     Taxjar,
 }

crates/api_models/src/payments.rs

@@ -2483,7 +2483,6 @@ pub enum BankRedirectData {
         /// The billing details for bank redirection
         billing_details: Option<BankRedirectBilling>,
         /// Bank account details for Giropay
-
         #[schema(value_type = Option<String>)]
         /// Bank account bic code
         bank_account_bic: Option<Secret<String>>,
@@ -4117,7 +4116,6 @@ pub struct ReceiverDetails {
 
 #[derive(Clone, Debug, PartialEq, serde::Serialize, ToSchema, router_derive::PolymorphicSchema)]
 #[generate_schemas(PaymentsCreateResponseOpenApi)]
-
 pub struct PaymentsResponse {
     /// Unique identifier for the payment. This ensures idempotency for multiple payments
     /// that have been done by a single merchant.
@@ -6247,7 +6245,7 @@ mod payment_id_type {
     struct PaymentIdVisitor;
     struct OptionalPaymentIdVisitor;
 
-    impl<'de> Visitor<'de> for PaymentIdVisitor {
+    impl Visitor<'_> for PaymentIdVisitor {
         type Value = PaymentIdType;
 
         fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
@@ -6321,7 +6319,7 @@ pub mod amount {
 
     // This is defined to provide guarded deserialization of amount
     // which itself handles zero and non-zero values internally
-    impl<'de> de::Visitor<'de> for AmountVisitor {
+    impl de::Visitor<'_> for AmountVisitor {
         type Value = Amount;
 
         fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
@@ -6517,7 +6515,6 @@ pub struct PaymentLinkStatusDetails {
 
 #[derive(Clone, Debug, serde::Deserialize, ToSchema, serde::Serialize)]
 #[serde(deny_unknown_fields)]
-
 pub struct PaymentLinkListConstraints {
     /// limit on the number of objects to return
     pub limit: Option<i64>,

crates/api_models/src/pm_auth.rs

@@ -22,7 +22,6 @@ pub struct LinkTokenCreateResponse {
 
 #[derive(Debug, Clone, serde::Deserialize, serde::Serialize)]
 #[serde(rename_all = "snake_case")]
-
 pub struct ExchangeTokenCreateRequest {
     pub public_token: String,
     pub client_secret: Option<String>,

crates/common_enums/src/transformers.rs

@@ -1913,7 +1913,7 @@ mod custom_serde {
 
         struct FieldVisitor;
 
-        impl<'de> Visitor<'de> for FieldVisitor {
+        impl Visitor<'_> for FieldVisitor {
             type Value = CountryAlpha2;
 
             fn expecting(&self, formatter: &mut Formatter<'_>) -> fmt::Result {
@@ -1945,7 +1945,7 @@ mod custom_serde {
 
         struct FieldVisitor;
 
-        impl<'de> Visitor<'de> for FieldVisitor {
+        impl Visitor<'_> for FieldVisitor {
             type Value = CountryAlpha3;
 
             fn expecting(&self, formatter: &mut Formatter<'_>) -> fmt::Result {
@@ -1977,7 +1977,7 @@ mod custom_serde {
 
         struct FieldVisitor;
 
-        impl<'de> Visitor<'de> for FieldVisitor {
+        impl Visitor<'_> for FieldVisitor {
             type Value = u32;
 
             fn expecting(&self, formatter: &mut Formatter<'_>) -> fmt::Result {

crates/common_utils/src/custom_serde.rs

@@ -202,7 +202,6 @@ pub mod timestamp {
 }
 
 /// <https://github.com/serde-rs/serde/issues/994#issuecomment-316895860>
-
 pub mod json_string {
     use serde::de::{self, Deserialize, DeserializeOwned, Deserializer};
     use serde_json;

crates/common_utils/src/types.rs

@@ -734,7 +734,7 @@ mod client_secret_type {
         {
             struct ClientSecretVisitor;
 
-            impl<'de> Visitor<'de> for ClientSecretVisitor {
+            impl Visitor<'_> for ClientSecretVisitor {
                 type Value = ClientSecret;
 
                 fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {

crates/common_utils/src/types/keymanager.rs

@@ -393,7 +393,7 @@ impl<'de> Deserialize<'de> for DecryptedData {
     {
         struct DecryptedDataVisitor;
 
-        impl<'de> Visitor<'de> for DecryptedDataVisitor {
+        impl Visitor<'_> for DecryptedDataVisitor {
             type Value = DecryptedData;
 
             fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
@@ -449,7 +449,7 @@ impl<'de> Deserialize<'de> for EncryptedData {
     {
         struct EncryptedDataVisitor;
 
-        impl<'de> Visitor<'de> for EncryptedDataVisitor {
+        impl Visitor<'_> for EncryptedDataVisitor {
             type Value = EncryptedData;
 
             fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {

crates/diesel_models/src/configs.rs

@@ -7,7 +7,6 @@ use crate::schema::configs;
 
 #[derive(Default, Clone, Debug, Insertable, Serialize, Deserialize)]
 #[diesel(table_name = configs)]
-
 pub struct ConfigNew {
     pub key: String,
     pub config: String,

crates/diesel_models/src/lib.rs

@@ -75,7 +75,6 @@ pub use self::{
 /// `Option<T>` values.
 ///
 /// [diesel-2.0-array-nullability]: https://diesel.rs/guides/migration_guide.html#2-0-0-nullability-of-array-elements
-
 #[doc(hidden)]
 pub(crate) mod diesel_impl {
     use diesel::{

crates/diesel_models/src/organization.rs

@@ -198,7 +198,6 @@ impl From<OrganizationUpdate> for OrganizationUpdateInternal {
     }
 }
 #[cfg(feature = "v2")]
-
 impl From<OrganizationUpdate> for OrganizationUpdateInternal {
     fn from(value: OrganizationUpdate) -> Self {
         match value {

crates/euclid/src/dssa/types.rs

@@ -18,7 +18,7 @@ pub enum CtxValueKind<'a> {
     Negation(&'a [dir::DirValue]),
 }
 
-impl<'a> CtxValueKind<'a> {
+impl CtxValueKind<'_> {
     pub fn get_assertion(&self) -> Option<&dir::DirValue> {
         if let Self::Assertion(val) = self {
             Some(val)

crates/euclid/src/frontend/ast/lowering.rs

@@ -25,7 +25,6 @@ use crate::{
 /// This serves for the purpose were we have the DirKey as an explicit Enum type and value as one
 /// of the member of the same Enum.
 /// So particularly it lowers a predefined Enum from DirKey to an Enum of DirValue.
-
 macro_rules! lower_enum {
     ($key:ident, $value:ident) => {
         match $value {
@@ -70,7 +69,6 @@ macro_rules! lower_enum {
 /// This is for the cases in which there are numerical values involved and they are lowered
 /// accordingly on basis of the supplied key, currently payment_amount is the only key having this
 /// use case
-
 macro_rules! lower_number {
     ($key:ident, $value:ident, $comp:ident) => {
         match $value {
@@ -117,7 +115,6 @@ macro_rules! lower_number {
 ///
 /// This serves for the purpose were we have the DirKey as Card_bin and value as an arbitrary string
 /// So particularly it lowers an arbitrary value to a predefined key.
-
 macro_rules! lower_str {
     ($key:ident, $value:ident $(, $validation_closure:expr)?) => {
         match $value {
@@ -155,7 +152,6 @@ macro_rules! lower_metadata {
 /// by throwing required errors for comparisons that can't be performed for a certain value type
 /// for example
 /// can't have greater/less than operations on enum types
-
 fn lower_comparison_inner<O: EuclidDirFilter>(
     comp: ast::Comparison,
 ) -> Result<Vec<dir::DirValue>, AnalysisErrorType> {

crates/euclid/src/frontend/ast/parser.rs

@@ -51,9 +51,9 @@ impl EuclidParsable for DummyOutput {
         )(input)
     }
 }
-pub fn skip_ws<'a, F, O>(inner: F) -> impl FnMut(&'a str) -> ParseResult<&str, O>
+pub fn skip_ws<'a, F, O>(inner: F) -> impl FnMut(&'a str) -> ParseResult<&'a str, O>
 where
-    F: FnMut(&'a str) -> ParseResult<&str, O> + 'a,
+    F: FnMut(&'a str) -> ParseResult<&'a str, O> + 'a,
 {
     sequence::preceded(pchar::multispace0, inner)
 }

crates/hyperswitch_connectors/src/connectors/nexinets/transformers.rs

@@ -122,7 +122,6 @@ pub struct NexinetsBankRedirects {
 
 #[derive(Debug, Serialize)]
 #[serde(rename_all = "camelCase")]
-
 pub struct NexinetsAsyncDetails {
     pub success_url: Option<String>,
     pub cancel_url: Option<String>,

crates/hyperswitch_connectors/src/connectors/razorpay/transformers.rs

@@ -58,7 +58,6 @@ pub struct RazorpayPaymentsRequest {
 
 #[derive(Default, Debug, Serialize, Eq, PartialEq)]
 #[serde(rename_all = "camelCase")]
-
 pub struct SecondFactor {
     txn_id: String,
     id: String,
@@ -980,7 +979,6 @@ pub struct RazorpaySyncResponse {
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
-
 pub enum PsyncStatus {
     Charged,
     Pending,
@@ -1053,7 +1051,6 @@ pub struct Refund {
 
 #[derive(Default, Debug, Serialize, Deserialize)]
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
-
 pub enum RefundStatus {
     Success,
     Failure,
@@ -1220,7 +1217,6 @@ impl From<RefundStatus> for enums::RefundStatus {
 
 #[derive(Default, Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
-
 pub struct RefundResponse {
     txn_id: Option<String>,
     refund: RefundRes,

crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs

@@ -456,7 +456,6 @@ pub struct TsysCaptureRequest {
 
 #[derive(Debug, Serialize)]
 #[serde(rename_all = "PascalCase")]
-
 pub struct TsysPaymentsCaptureRequest {
     capture: TsysCaptureRequest,
 }

crates/hyperswitch_connectors/src/utils.rs

@@ -119,7 +119,7 @@ where
 
 pub(crate) fn missing_field_err(
     message: &'static str,
-) -> Box<dyn Fn() -> error_stack::Report<errors::ConnectorError> + '_> {
+) -> Box<dyn Fn() -> error_stack::Report<errors::ConnectorError> + 'static> {
     Box::new(move || {
         errors::ConnectorError::MissingRequiredField {
             field_name: message,

crates/hyperswitch_domain_models/src/merchant_account.rs

@@ -255,7 +255,6 @@ pub enum MerchantAccountUpdate {
 }
 
 #[cfg(feature = "v1")]
-
 impl From<MerchantAccountUpdate> for MerchantAccountUpdateInternal {
     fn from(merchant_account_update: MerchantAccountUpdate) -> Self {
         let now = date_time::now();

crates/hyperswitch_interfaces/src/secrets_interface.rs

@@ -15,7 +15,6 @@ pub trait SecretManagementInterface: Send + Sync {
     //     &self,
     //     input: Secret<String>,
     // ) -> CustomResult<String, SecretsManagementError>;
-
     /// Given an input, decrypt/retrieve the secret
     async fn get_secret(
         &self,

crates/masking/src/diesel.rs

@@ -13,7 +13,7 @@ use diesel::{
 
 use crate::{Secret, Strategy, StrongSecret, ZeroizableSecret};
 
-impl<'expr, S, I, T> AsExpression<T> for &'expr Secret<S, I>
+impl<S, I, T> AsExpression<T> for &Secret<S, I>
 where
     T: sql_types::SingleValue,
     I: Strategy<S>,
@@ -24,7 +24,7 @@ where
     }
 }
 
-impl<'expr2, 'expr, S, I, T> AsExpression<T> for &'expr2 &'expr Secret<S, I>
+impl<S, I, T> AsExpression<T> for &&Secret<S, I>
 where
     T: sql_types::SingleValue,
     I: Strategy<S>,
@@ -81,7 +81,7 @@ where
     }
 }
 
-impl<'expr, S, I, T> AsExpression<T> for &'expr StrongSecret<S, I>
+impl<S, I, T> AsExpression<T> for &StrongSecret<S, I>
 where
     T: sql_types::SingleValue,
     S: ZeroizableSecret,
@@ -93,7 +93,7 @@ where
     }
 }
 
-impl<'expr2, 'expr, S, I, T> AsExpression<T> for &'expr2 &'expr StrongSecret<S, I>
+impl<S, I, T> AsExpression<T> for &&StrongSecret<S, I>
 where
     T: sql_types::SingleValue,
     S: ZeroizableSecret,

crates/masking/src/maskable.rs

@@ -79,10 +79,8 @@ impl<T: Eq + PartialEq + Clone> Maskable<T> {
 }
 
 /// Trait for providing a method on custom types for constructing `Maskable`
-
 pub trait Mask {
     /// The type returned by the `into_masked()` method. Must implement `PartialEq`, `Eq` and `Clone`
-
     type Output: Eq + Clone + PartialEq;
 
     ///

crates/masking/src/serde.rs

@@ -118,7 +118,7 @@ impl<T: Serialize + ErasedSerialize> ErasedMaskSerialize for T {
     }
 }
 
-impl<'a> Serialize for dyn ErasedMaskSerialize + 'a {
+impl Serialize for dyn ErasedMaskSerialize + '_ {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: Serializer,
@@ -127,7 +127,7 @@ impl<'a> Serialize for dyn ErasedMaskSerialize + 'a {
     }
 }
 
-impl<'a> Serialize for dyn ErasedMaskSerialize + 'a + Send {
+impl Serialize for dyn ErasedMaskSerialize + '_ + Send {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: Serializer,