Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payouts): extend routing capabilities to payout operation #3531

Merged
merged 23 commits into from
Feb 26, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Feb 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Explained in issue #1845

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested locally using Postman collection for payouts routing - https://postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-a04b7f48-7689-4eac-8a84-9b5c5af8ba50?action=share&creator=9906252

Steps for testing
Assuming merchant account and payout connectors are created.

All these steps can be found in the linked postman collection.

  1. Add a volume split rule
  2. Activate this rule
  3. Create multiple payouts (and check the connectors being evaluated in the response)
  4. Deactivate this rule
  5. Add an advanced split rule
  6. Create multiple payouts (and check the connectors being evaluated in the response))
  7. Activate this rule
  8. Deactivate this rule

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m self-assigned this Feb 2, 2024
@kashif-m kashif-m marked this pull request as ready for review February 7, 2024 08:28
@kashif-m kashif-m requested review from a team as code owners February 7, 2024 08:28
@kashif-m kashif-m requested a review from Sakilmostak February 7, 2024 08:28
@kashif-m kashif-m mentioned this pull request Feb 13, 2024
@kashif-m kashif-m requested a review from vspecky February 16, 2024 07:36
@kashif-m kashif-m requested a review from a team as a code owner February 21, 2024 11:27
@prajjwalkumar17
Copy link
Contributor

Hey @kashif-m
Can we first of all check on the failing MSRV tests and probably once regenerate the Open-api spec file.

Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a mandatory review from @vspecky as the changes are intersecting most of the euclidian family crates.

cc: @vspecky @tinu-hareesswar @Gnanasundari24

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 75c633f Feb 26, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the payout_routing branch February 26, 2024 07:44
@kashif-m kashif-m restored the payout_routing branch February 29, 2024 03:38
@kashif-m kashif-m deleted the payout_routing branch February 29, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants