Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): handle empty body parse failures in bad request logger middleware #3544

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix(router): handle empty body parse failures in bad request logger middleware #3544

merged 1 commit into from
Feb 5, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

handle empty body parse failures in bad request logger middleware

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Main PR - #3541

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Feb 5, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner February 5, 2024 10:23
@sai-harsha-vardhan sai-harsha-vardhan changed the base branch from main to hotfix-2024.02.02.0 February 5, 2024 10:24
@Gnanasundari24 Gnanasundari24 merged commit efffc1e into hotfix-2024.02.02.0 Feb 5, 2024
15 of 19 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-empty-body-parse-failures-hotfix branch February 5, 2024 11:18
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsampras lsampras lsampras approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sai-harsha-vardhan @lsampras @Narayanbhat166 @pixincreate @Gnanasundari24