Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(healthcheck): do not return true as response if the check if not applicable #3551

Merged
merged 5 commits into from
Feb 13, 2024
Merged

fix(healthcheck): do not return true as response if the check if not applicable #3551

merged 5 commits into from
Feb 13, 2024

Conversation

dracarys18
Copy link
Member

@dracarys18 dracarys18 commented Feb 5, 2024 •
edited
Loading

Type of Change

  • Bugfix

Description

Don't return true on the places where checks or not applicable

Motivation and Context

This fixes misconception in health check where it would return true even in case if the case is not checked.

How did you test it?

  • Disable locker in config
curl --location 'http://localhost:8080/health/ready'
Screenshot 2024-02-07 at 2 55 21 PM

THIS CANNOT BE TESTED IN SANDBOX

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 5, 2024
@dracarys18 dracarys18 added this to the December 2023 Release milestone Feb 5, 2024
@dracarys18 dracarys18 self-assigned this Feb 5, 2024
@dracarys18 dracarys18 requested review from a team as code owners February 5, 2024 11:48
@dracarys18 dracarys18 linked an issue Feb 5, 2024 that may be closed by this pull request
[FIX] dont return true in case health check is not done on the component #3553
Closed
Chethan-rao
Chethan-rao previously approved these changes Feb 6, 2024
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@dracarys18 dracarys18 changed the title fix(healthcheck): don't return true as response if the check if NA fix(healthcheck): don't return true as response if the check if not applicable Feb 12, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 12, 2024
@dracarys18 dracarys18 changed the title fix(healthcheck): don't return true as response if the check if not applicable fix(healthcheck): do not return true as response if the check if not applicable Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 6e103ce Feb 13, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the add_non_applicable_status branch February 13, 2024 07:58
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@Chethan-rao Chethan-rao Chethan-rao approved these changes

Assignees

@dracarys18 dracarys18

Labels
A-core Area: Core flows
Projects
None yet
Milestone
February 2024 Release
Development

Successfully merging this pull request may close these issues.

[FIX] dont return true in case health check is not done on the component
6 participants
@dracarys18 @NishantJoshi00 @Chethan-rao @SanchithHegde @bernard-eugine @likhinbopanna