Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api_models): add client_secret type to payments #3557

Merged
merged 6 commits into from
Feb 15, 2024
Merged

feat(api_models): add client_secret type to payments #3557

merged 6 commits into from
Feb 15, 2024

Conversation

wowinter13
Copy link
Contributor

@wowinter13 wowinter13 commented Feb 5, 2024 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implement ClientSecret type for payments.

Closes #1357

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Added and ran unit tests successfully.

Maintainer edit: This PR only adds a newtype and is not being used anywhere in code, this should not affect any existing application behavior.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@wowinter13 wowinter13 requested a review from a team as a code owner February 5, 2024 22:29
@wowinter13
Copy link
Contributor Author

@SanchithHegde @deepanshu-iiitu @Abhicodes-crypto hello there guys
Could you check please if I am going in the right direction?

@Narayanbhat166
Copy link
Member

apart from the minor nit, LGTM!

Narayanbhat166
Narayanbhat166 previously approved these changes Feb 13, 2024
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @wowinter13!

@wowinter13
Copy link
Contributor Author

@SanchithHegde
thanks! Just ping me in case there are any comments to address

@SanchithHegde SanchithHegde added the C-feature Category: Feature request or enhancement label Feb 13, 2024
@SanchithHegde
Copy link
Member

Hey @wowinter13, could you address the failing CI checks?

@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 15, 2024
Merged via the queue into juspay:main with commit 610a5a3 Feb 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@wowinter13 wowinter13

Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add domain type for client secret
4 participants
@wowinter13 @Narayanbhat166 @SanchithHegde @likhinbopanna