Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user): implement force password reset #3572

Merged
merged 5 commits into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/api_models/src/user/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ pub enum SetMetaDataRequest {
ConfigureWoocom,
SetupWoocomWebhook,
IsMultipleConfiguration,
#[serde(skip)]
IsChangePasswordRequired,
}

#[derive(Debug, serde::Deserialize, serde::Serialize)]
Expand Down Expand Up @@ -110,6 +112,7 @@ pub enum GetMetaDataRequest {
ConfigureWoocom,
SetupWoocomWebhook,
IsMultipleConfiguration,
IsChangePasswordRequired,
}

#[derive(Debug, serde::Deserialize, serde::Serialize)]
Expand Down Expand Up @@ -146,4 +149,5 @@ pub enum GetMetaDataResponse {
ConfigureWoocom(bool),
SetupWoocomWebhook(bool),
IsMultipleConfiguration(bool),
IsChangePasswordRequired(bool),
}
1 change: 1 addition & 0 deletions crates/diesel_models/src/enums.rs
Original file line number Diff line number Diff line change
Expand Up @@ -511,4 +511,5 @@ pub enum DashboardMetadata {
ConfigureWoocom,
SetupWoocomWebhook,
IsMultipleConfiguration,
IsChangePasswordRequired,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a migration change right @apoorvdixit88?

}
16 changes: 16 additions & 0 deletions crates/diesel_models/src/query/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,20 @@ impl DashboardMetadata {
)
.await
}

pub async fn delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
conn: &PgPooledConn,
user_id: String,
merchant_id: String,
data_key: enums::DashboardMetadata,
) -> StorageResult<bool> {
generics::generic_delete::<<Self as HasTable>::Table, _>(
conn,
dsl::user_id
.eq(user_id)
.and(dsl::merchant_id.eq(merchant_id))
.and(dsl::data_key.eq(data_key)),
)
.await
}
}
47 changes: 42 additions & 5 deletions crates/router/src/core/user.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
use api_models::user::{self as user_api, InviteMultipleUserResponse};
use api_models::user::{
self as user_api, dashboard_metadata::SetMetaDataRequest, InviteMultipleUserResponse,
};
#[cfg(feature = "email")]
use diesel_models::user_role::UserRoleUpdate;
use diesel_models::{enums::UserStatus, user as storage_user, user_role::UserRoleNew};
use diesel_models::{enums, enums::UserStatus, user as storage_user, user_role::UserRoleNew};
#[cfg(feature = "email")]
use error_stack::IntoReport;
use error_stack::ResultExt;
Expand All @@ -11,6 +13,7 @@ use router_env::env;
#[cfg(feature = "email")]
use router_env::logger;

use self::dashboard_metadata::set_metadata;
use super::errors::{UserErrors, UserResponse, UserResult};
#[cfg(feature = "email")]
use crate::services::email::types as email_types;
Expand Down Expand Up @@ -308,6 +311,19 @@ pub async fn change_password(
.await
.change_context(UserErrors::InternalServerError)?;

#[cfg(not(feature = "email"))]
{
state
.store
.delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&user_from_token.user_id,
&user_from_token.merchant_id,
enums::DashboardMetadata::IsChangePasswordRequired,
)
.await
.ok();
}

Ok(ApplicationResponse::StatusOk)
}

Expand Down Expand Up @@ -475,11 +491,11 @@ pub async fn invite_user(
.insert_user_role(UserRoleNew {
user_id: new_user.get_user_id().to_owned(),
merchant_id: user_from_token.merchant_id.clone(),
role_id: request.role_id,
org_id: user_from_token.org_id,
role_id: request.role_id.clone(),
org_id: user_from_token.org_id.clone(),
status: invitation_status,
created_by: user_from_token.user_id.clone(),
last_modified_by: user_from_token.user_id,
last_modified_by: user_from_token.user_id.clone(),
created_at: now,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have to clone this probably.

last_modified: now,
})
Expand Down Expand Up @@ -515,6 +531,16 @@ pub async fn invite_user(
#[cfg(not(feature = "email"))]
{
is_email_sent = false;
let invited_user_token = auth::UserFromToken {
user_id: new_user.get_user_id(),
merchant_id: user_from_token.merchant_id.clone(),
org_id: user_from_token.org_id.clone(),
role_id: request.role_id.clone(),
};

let r_request = SetMetaDataRequest::IsChangePasswordRequired;

set_metadata(state.clone(), invited_user_token, r_request).await?;
}

Ok(ApplicationResponse::Json(user_api::InviteUserResponse {
Expand Down Expand Up @@ -692,6 +718,17 @@ async fn handle_new_user_invitation(
#[cfg(not(feature = "email"))]
{
is_email_sent = false;

let invited_user_token = auth::UserFromToken {
user_id: new_user.get_user_id(),
merchant_id: user_from_token.merchant_id.clone(),
org_id: user_from_token.org_id.clone(),
role_id: request.role_id.clone(),
};

let r_request = SetMetaDataRequest::IsChangePasswordRequired;

set_metadata(state.clone(), invited_user_token, r_request).await?;
}

Ok(InviteMultipleUserResponse {
Expand Down
18 changes: 18 additions & 0 deletions crates/router/src/core/user/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ fn parse_set_request(data_enum: api::SetMetaDataRequest) -> UserResult<types::Me
api::SetMetaDataRequest::IsMultipleConfiguration => {
Ok(types::MetaData::IsMultipleConfiguration(true))
}
api::SetMetaDataRequest::IsChangePasswordRequired => {
Ok(types::MetaData::IsChangePasswordRequired(true))
}
}
}

Expand All @@ -131,6 +134,7 @@ fn parse_get_request(data_enum: api::GetMetaDataRequest) -> DBEnum {
api::GetMetaDataRequest::ConfigureWoocom => DBEnum::ConfigureWoocom,
api::GetMetaDataRequest::SetupWoocomWebhook => DBEnum::SetupWoocomWebhook,
api::GetMetaDataRequest::IsMultipleConfiguration => DBEnum::IsMultipleConfiguration,
api::GetMetaDataRequest::IsChangePasswordRequired => DBEnum::IsChangePasswordRequired,
}
}

Expand Down Expand Up @@ -207,6 +211,9 @@ fn into_response(
DBEnum::IsMultipleConfiguration => Ok(api::GetMetaDataResponse::IsMultipleConfiguration(
data.is_some(),
)),
DBEnum::IsChangePasswordRequired => Ok(api::GetMetaDataResponse::IsChangePasswordRequired(
data.is_some(),
)),
}
}

Expand Down Expand Up @@ -520,6 +527,17 @@ async fn insert_metadata(
)
.await
}
types::MetaData::IsChangePasswordRequired(data) => {
utils::insert_user_scoped_metadata_to_db(
state,
user.user_id,
user.merchant_id,
user.org_id,
metadata_key,
data,
)
.await
}
}
}

Expand Down
55 changes: 55 additions & 0 deletions crates/router/src/db/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ pub trait DashboardMetadataInterface {
&self,
metadata: storage::DashboardMetadataNew,
) -> CustomResult<storage::DashboardMetadata, errors::StorageError>;

async fn update_metadata(
&self,
user_id: Option<String>,
Expand All @@ -30,6 +31,7 @@ pub trait DashboardMetadataInterface {
org_id: &str,
data_keys: Vec<enums::DashboardMetadata>,
) -> CustomResult<Vec<storage::DashboardMetadata>, errors::StorageError>;

async fn find_merchant_scoped_dashboard_metadata(
&self,
merchant_id: &str,
Expand All @@ -42,6 +44,13 @@ pub trait DashboardMetadataInterface {
user_id: &str,
merchant_id: &str,
) -> CustomResult<bool, errors::StorageError>;

async fn delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&self,
user_id: &str,
merchant_id: &str,
data_key: enums::DashboardMetadata,
) -> CustomResult<bool, errors::StorageError>;
}

#[async_trait::async_trait]
Expand Down Expand Up @@ -132,6 +141,24 @@ impl DashboardMetadataInterface for Store {
.map_err(Into::into)
.into_report()
}

async fn delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&self,
user_id: &str,
merchant_id: &str,
data_key: enums::DashboardMetadata,
) -> CustomResult<bool, errors::StorageError> {
let conn = connection::pg_connection_write(self).await?;
storage::DashboardMetadata::delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&conn,
user_id.to_owned(),
merchant_id.to_owned(),
data_key,
)
.await
.map_err(Into::into)
.into_report()
}
}

#[async_trait::async_trait]
Expand Down Expand Up @@ -294,4 +321,32 @@ impl DashboardMetadataInterface for MockDb {

Ok(true)
}

async fn delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&self,
user_id: &str,
merchant_id: &str,
data_key: enums::DashboardMetadata,
) -> CustomResult<bool, errors::StorageError> {
let mut dashboard_metadata = self.dashboard_metadata.lock().await;

let dashboard_metadata_index = dashboard_metadata
.iter()
.position(|metadata_inner| {
metadata_inner
.user_id
.clone()
.map(|user_id_inner| user_id_inner == user_id)
.unwrap_or(false)
&& metadata_inner.merchant_id == merchant_id
&& metadata_inner.data_key == data_key
})
.ok_or(errors::StorageError::ValueNotFound(format!(
"No data found"
)))?;

dashboard_metadata.remove(dashboard_metadata_index);

Ok(true)
}
}
17 changes: 17 additions & 0 deletions crates/router/src/db/kafka_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1964,6 +1964,7 @@ impl UserRoleInterface for KafkaStore {
.update_user_role_by_user_id_merchant_id(user_id, merchant_id, update)
.await
}

async fn delete_user_role_by_user_id_merchant_id(
&self,
user_id: &str,
Expand Down Expand Up @@ -2021,6 +2022,7 @@ impl DashboardMetadataInterface for KafkaStore {
.find_user_scoped_dashboard_metadata(user_id, merchant_id, org_id, data_keys)
.await
}

async fn find_merchant_scoped_dashboard_metadata(
&self,
merchant_id: &str,
Expand All @@ -2041,6 +2043,21 @@ impl DashboardMetadataInterface for KafkaStore {
.delete_user_scoped_dashboard_metadata_by_merchant_id(user_id, merchant_id)
.await
}

async fn delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
&self,
user_id: &str,
merchant_id: &str,
data_key: enums::DashboardMetadata,
) -> CustomResult<bool, errors::StorageError> {
self.diesel_store
.delete_user_scoped_dashboard_metadata_by_merchant_id_data_key(
user_id,
merchant_id,
data_key,
)
.await
}
}

#[async_trait::async_trait]
Expand Down
2 changes: 2 additions & 0 deletions crates/router/src/types/domain/user/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ pub enum MetaData {
ConfigureWoocom(bool),
SetupWoocomWebhook(bool),
IsMultipleConfiguration(bool),
IsChangePasswordRequired(bool),
}

impl From<&MetaData> for DBEnum {
Expand All @@ -51,6 +52,7 @@ impl From<&MetaData> for DBEnum {
MetaData::ConfigureWoocom(_) => Self::ConfigureWoocom,
MetaData::SetupWoocomWebhook(_) => Self::SetupWoocomWebhook,
MetaData::IsMultipleConfiguration(_) => Self::IsMultipleConfiguration,
MetaData::IsChangePasswordRequired(_) => Self::IsChangePasswordRequired,
}
}
}
Expand Down
4 changes: 3 additions & 1 deletion crates/router/src/utils/user/dashboard_metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ pub fn separate_metadata_type_based_on_scope(
| DBEnum::ConfigureWoocom
| DBEnum::SetupWoocomWebhook
| DBEnum::IsMultipleConfiguration => merchant_scoped.push(key),
DBEnum::Feedback | DBEnum::ProdIntent => user_scoped.push(key),
DBEnum::Feedback | DBEnum::ProdIntent | DBEnum::IsChangePasswordRequired => {
user_scoped.push(key)
}
}
}
(merchant_scoped, user_scoped)
Expand Down
Loading