Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(users): change list roles api to also send inactive merchants #3583

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ThisIsMani
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Changed switch list api to also send inactive merchants in the response.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To use this in this api to get all the merchant details

How did you test it?

curl --location 'http://localhost:8080/user/switch/list' \
--header 'Authorization: Bearer JWT'

This api will send merchants with is_active: false in the response from now on.

[
    {
        "merchant_id": "merchant_1",
        "merchant_name": null,
        "is_active": false
    },
    {
        "merchant_id": "merchant_2",
        "merchant_name": null,
        "is_active": true
    }
]

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ThisIsMani ThisIsMani added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor A-users Area: Users labels Feb 7, 2024
@ThisIsMani ThisIsMani self-assigned this Feb 7, 2024
@ThisIsMani ThisIsMani requested a review from a team as a code owner February 7, 2024 12:48
@ThisIsMani ThisIsMani linked an issue Feb 7, 2024 that may be closed by this pull request
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit cef1643 Feb 7, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the list_all_roles branch February 7, 2024 14:09
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: change list roles api to also send inactive merchants
5 participants