Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pm_list): add pm list support for voucher #3613

Closed
wants to merge 1 commit into from

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented Feb 9, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

In Adyen do payment connector create with having voucher payment_methods_enabled enabled

`{
            "payment_method": "voucher",
            "payment_method_types": [
                {
                    "payment_method_type": "boleto",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }`

Then list payment methods for merchant , we should get "payment_method": "voucher", inside payment_methods

 "payment_methods": [
        {
            "payment_method": "voucher",
            "payment_method_types": [
                {
                    "payment_method_type": "boleto",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": null,
                    "bank_debits": null,
                    "bank_transfers": null,
                    "voucher": {
                        "eligible_connectors": [
                            "adyen"
                        ]
                    },
                    "required_fields": null,
                    "surcharge_details": null,
                    "pm_auth_connector": null
                }
            ]
        }
    ],
Screenshot 2024-02-09 at 7 18 00 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added A-core Area: Core flows M-api-contract-changes Metadata: This PR involves API contract changes labels Feb 9, 2024
@swangi-kumari swangi-kumari self-assigned this Feb 9, 2024
@swangi-kumari swangi-kumari requested review from a team as code owners February 9, 2024 14:02
@swangi-kumari
Copy link
Contributor Author

This feature already exist, so closing this PR.

@SanchithHegde SanchithHegde deleted the pm-list-for-voucher branch March 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant