Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(postman): update rustman and collection generation docs #3615

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Feb 9, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR updates the Rustman documentation easing the collection development process along with the things to look for before running the collection.

Closes #3616

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The documentation misses some key points which is why some of the developers and contributors are finding it difficult to test their work.

How did you test it?

Below 2 files look cleaner and clearer:

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@pixincreate pixincreate requested a review from a team as a code owner February 9, 2024 18:43
@pixincreate pixincreate self-assigned this Feb 9, 2024
@pixincreate pixincreate added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 9, 2024
@pixincreate pixincreate added this to the February 2024 Release milestone Feb 9, 2024
@pixincreate pixincreate changed the title Rustman doc docs(postman): update rustman and collection generation docs Feb 9, 2024
@@ -26,10 +26,11 @@ This directory contains the Postman collection for all Hyperswitch supported con

- Make sure that you update the `tests` section where the necessary `javascript` code has to written/updated to test the feature (assertion checks where you verify the results obtained with the expected outcome)
- If certain `tests` need to be run at the time of making a request, make sure you add them to the `Pre-request Script` section of the request
- Make sure that the request body does not contain any comments else the `newman dir-export` command will fail which is used to export the collection to its directory structure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postman does allow using JSON comments in request bodies though:
https://blog.postman.com/introducing-support-for-json-comments-in-request-body/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the dir-export command fails. Might have to check with @knutties to fix it.

@pixincreate pixincreate added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 02652a2 Feb 13, 2024
10 of 12 checks passed
@pixincreate pixincreate deleted the rustman-doc branch February 13, 2024 07:33
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-doc Category: Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Update Rustman documentation
3 participants