Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: noon payme cryptopay error mapping #3656

Closed
wants to merge 1 commit into from
Closed

feat: noon payme cryptopay error mapping #3656

wants to merge 1 commit into from

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Feb 15, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Cherry picked this commit off this PR. #3258

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 @sahkal @hyperswitch-bot
feat: noon payme cryptopay error mapping (#3258)
2babf95 
Co-authored-by: Sahkal Poddar <[email protected]>
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 15, 2024
@hrithikesh026 hrithikesh026 self-assigned this Feb 15, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner February 15, 2024 08:32
@hrithikesh026
Copy link
Contributor Author

Closing since no longer required

@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 23, 2024
@SanchithHegde SanchithHegde deleted the fix/error_mapping_for_noon_payme_cryptopay branch June 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrithikesh026 @SanchithHegde