Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: auth analytics queries re write #5581

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: auth analytics queries re write #5581

wants to merge 4 commits into from

Conversation

Sanskar2001
Copy link

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sanskar2001 Sanskar2001 requested a review from a team as a code owner August 9, 2024 10:29
@Sanskar2001 Sanskar2001 force-pushed the auth-analytics-refactor branch from dcb963f to d23d9e5 Compare August 9, 2024 10:33
@Sanskar2001 Sanskar2001 self-assigned this Aug 9, 2024
@vsrivatsa-edinburgh vsrivatsa-edinburgh linked an issue Aug 9, 2024 that may be closed by this pull request
[FEATURE] Authentication Analytics #4252
Open
2 tasks
@Sanskar2001 Sanskar2001 force-pushed the auth-analytics-refactor branch from 4ab1d28 to 1587791 Compare August 12, 2024 08:29
@hyperswitch-bot hyperswitch-bot bot requested a review from a team as a code owner August 12, 2024 08:32
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 12, 2024
vsrivatsa-edinburgh
vsrivatsa-edinburgh reviewed Sep 16, 2024
View reviewed changes
crates/analytics/src/auth_events/metrics/authentication_count.rs

query_builder
.add_filter_clause("event_name", SdkEventNames::ThreeDsMethod)
.add_filter_clause("merchant_id", _merchant_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.add_filter_clause("merchant_id", _merchant_id)
.add_filter_clause("merchant_id", merchant_id)

rename function argument as well

vsrivatsa-edinburgh
vsrivatsa-edinburgh reviewed Sep 16, 2024
View reviewed changes
crates/analytics/src/auth_events/metrics/frictionless_flow_count.rs

query_builder
.add_filter_clause("event_name", SdkEventNames::DisplayThreeDsSdk)
.add_filter_clause("merchant_id", _merchant_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.add_filter_clause("merchant_id", _merchant_id)
.add_filter_clause("merchant_id", merchant_id)

@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsrivatsa-edinburgh vsrivatsa-edinburgh vsrivatsa-edinburgh left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@Sanskar2001 Sanskar2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Authentication Analytics
2 participants
@Sanskar2001 @vsrivatsa-edinburgh