feat(connector): [JPMORGAN, PAYU, DIGITALVIRGO, PAYBOX, BITPAY, HELCIM] added in feature matrix api #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
bsayak03
force-pushed
the
ft_matrix
branch
2 times, most recently
from
d2bcd6b to
0539e06
Compare
AkshayaFoiger
requested changes
Feb 3, 2025
There was a problem hiding this comment.
remove validate_connector_against_payment_request()
| specific_features: Some( | ||
| api_models::feature_matrix::PaymentMethodSpecificFeatures::Card({ | ||
| api_models::feature_matrix::CardSpecificFeatures { | ||
| three_ds: common_enums::FeatureStatus::NotSupported, // but docs has support |
There was a problem hiding this comment.
Why are we adding this comment ?
There was a problem hiding this comment.
we can ignore this, removing the comment
There was a problem hiding this comment.
remove validate_connector_against_payment_request()
There was a problem hiding this comment.
remove validate_connector_against_payment_request()
bsayak03
force-pushed
the
ft_matrix
branch
2 times, most recently
from
2a6e175 to
1e00527
Compare
bsayak03
changed the title
bsayak03
changed the title
AkshayaFoiger
previously approved these changes
Feb 20, 2025
deepanshu-iiitu
previously approved these changes
Feb 20, 2025
ShankarSinghC
previously approved these changes
Feb 21, 2025
bsayak03
dismissed stale reviews from ShankarSinghC, deepanshu-iiitu, and AkshayaFoiger
via
6b274c4
AkshayaFoiger
approved these changes
Feb 21, 2025
ShankarSinghC
approved these changes
Feb 21, 2025
deepanshu-iiitu
approved these changes
Feb 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Fixes juspay/hyperswitch-cloud#8276
Description
Added details feature api details for Jpmorgan, Payu, Digital Virgo.
Additional Changes
Motivation and Context
How did you test it?
Request :
curl --location 'http://localhost:8080/feature_matrix' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_vE*****DCUv82mKkL'Response :
Checklist
cargo +nightly fmt --allcargo clippy