-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): Add v2 endpoint to retrieve payment filters at merchant and profile level #7171
Open
aniketburman014
wants to merge
22
commits into
main
Choose a base branch
from
Filter_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
Narayanbhat166
requested changes
Feb 7, 2025
Narayanbhat166
requested changes
Feb 18, 2025
Narayanbhat166
previously approved these changes
Feb 19, 2025
jarnura
previously approved these changes
Feb 19, 2025
ShankarSinghC
previously approved these changes
Feb 20, 2025
crates/router/src/core/payments.rs
Outdated
.extend( | ||
payment_method_types_vec | ||
.iter() | ||
.filter_map(|p| p.get_payment_method_type()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Consider avoiding single-letter variable names like p. It's generally more readable to use more descriptive names that convey the purpose of the variable.
5ca22cf
Narayanbhat166
previously approved these changes
Feb 21, 2025
ShankarSinghC
previously approved these changes
Feb 21, 2025
fe68b30
Narayanbhat166
approved these changes
Feb 25, 2025
jarnura
approved these changes
Feb 25, 2025
ShankarSinghC
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added the
v2/payments/filter
andv2/payments/profile/filter
API to retrieve available payment filters (connectors, statuses, payment methods, authentication types, etc.) at merchant and profile level.Key Changes
Additional Changes
Links to the files with corresponding changes.
crates/api_models/src/admin.rs
crates/api_models/src/payment_methods.rs
crates/router/src/routes/payments.rs
crates/common_types/src/payment_methods.rs
crates/router/Cargo.toml
crates/router/src/core/payments.rs
crates/router/src/routes/app.rs
Motivation and Context
How did you test it?
-Request
Checklist
cargo +nightly fmt --all
cargo clippy