feat(router): add proxy-confirm-intent api for payments in v2 flow #7215

AdityaKumaar21 · 2025-02-07T11:10:39Z

Type of Change

Description

Developed the proxy-confirm-intent API, specifically designed for Merchant-Initiated Transactions (MIT) payments. This is a generic and reusable API that facilitates MIT payment confirmations.
Its working is similar to confirm-intent api but in proxy flow we will be not having customer's details, rather we need mca_id and psp_token in order to confirm intent.
This API will help in PCR as it totally depends on recurring payments(MIT transaction) so, it needs proxy-confirm-intent.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

cURL:-

curl --location 'http://localhost:8080/v2/payments/12345_pay_01953c48fdf57f5394faf843bf06187e/proxy-confirm-intent' \
--header 'x-profile-id: pro_73hfy7wgWWd7ujLBjvrJ' \
--header 'x-client-secret: 12345_pay_01953c48fdf57f5394faf843bf06187e_secret_01953c48fdff7da3983c22d6b08c811d' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_bPve88AB4DOwPb7YWfDFFqsddBaC*************************************' \
--data '{
    "amount":{
        "order_amount":100,
        "currency":"USD"
    },
    "recurring_details":{
        "processor_payment_token":"card_1QqvxW06IkU6uKNZuPtSKnJ5"
    },
    "connector":"stripe",
    "merchant_connector_id":"mca_lXRIeVR2IPZXA2hpSSpO"
}'

edited create_intent cURL(added feature_metadata field):-

{
    "amount_details": {
        "order_amount": 100,
        "currency": "USD"
    },
    "capture_method":"automatic",
    "authentication_type": "no_three_ds",
    "billing": {
        "address": {
            "first_name": "John",
            "last_name": "Dough"
        },
        "email": "[email protected]"
    },
    "shipping": {
        "address": {
            "first_name": "John",
            "last_name": "Dough",
            "city": "Karwar",
            "zip": "581301",
            "state": "Karnataka"
        },
        "email": "[email protected]"
    },
    "feature_metadata":{
        "payment_revenue_recovery_metadata":{
            "total_retry_count":3,
            "payment_connector_transmission":"ConnectorCallSucceeded",
            "billing_connector_id":"{{mca_id}}",
            "active_attempt_payment_connector_id":"{{mca_id}}",
            "billing_connector_payment_details":{
                "payment_processor_token":"card_1QqvxW06IkU6uKNZuPtSKnJ5",
                "connector_customer_id":"cus_RkQYGuTepCnglS"
            },
            "payment_method_type": "card",
            "payment_method_subtype": "credit"
        }
    }
}

Response:-

{
    "id": "12345_pay_01953c48fdf57f5394faf843bf06187e",
    "status": "succeeded",
    "amount": {
        "order_amount": 1000,
        "currency": "USD",
        "shipping_cost": null,
        "order_tax_amount": null,
        "external_tax_calculation": "skip",
        "surcharge_calculation": "skip",
        "surcharge_amount": null,
        "tax_on_surcharge": null,
        "net_amount": 1000,
        "amount_to_capture": null,
        "amount_capturable": 0,
        "amount_captured": 1000
    },
    "customer_id": null,
    "connector": "stripe",
    "client_secret": "12345_pay_01953c48fdf57f5394faf843bf06187e_secret_01953c48fdff7da3983c22d6b08c811d",
    "created": "2025-02-25T08:46:11.456Z",
    "payment_method_data": {
        "billing": null
    },
    "payment_method_type": "card",
    "payment_method_subtype": "debit",
    "next_action": null,
    "connector_transaction_id": "pi_3QwJmO06IkU6uKNZ0QVgMCLQ",
    "connector_reference_id": null,
    "connector_token_details": {
        "token": "card_1QqvxW06IkU6uKNZuPtSKnJ5"
    },
    "merchant_connector_id": "mca_lXRIeVR2IPZXA2hpSSpO",
    "browser_info": null,
    "error": null,
    "authentication_type": "no_three_ds",
    "applied_authentication_type": "no_three_ds"
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…in payment intent for v2 flow

semanticdiff-com · 2025-02-07T11:10:42Z

Review changes with

Changed Files

File	Status
crates/diesel_models/src/payment_intent.rs	80% smaller
crates/router/src/routes/lock_utils.rs	37% smaller
crates/router/src/routes/app.rs	17% smaller
crates/api_models/src/events/payment.rs	1% smaller
crates/hyperswitch_domain_models/src/payments/payment_attempt.rs	1% smaller
.typos.toml	Unsupported file format
crates/api_models/src/payments.rs	0% smaller
crates/diesel_models/src/payment_attempt.rs	0% smaller
crates/diesel_models/src/types.rs	0% smaller
crates/hyperswitch_domain_models/src/payments.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_intent.rs	0% smaller
crates/hyperswitch_domain_models/src/router_data.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types.rs	0% smaller
crates/router/src/core/payments.rs	0% smaller
crates/router/src/core/payments/operations.rs	0% smaller
crates/router/src/core/payments/operations/payment_confirm_intent.rs	0% smaller
crates/router/src/core/payments/operations/proxy_payments_intent.rs	0% smaller
crates/router/src/core/payments/transformers.rs	0% smaller
crates/router/src/routes/payments.rs	0% smaller
crates/router_env/src/logger/types.rs	0% smaller

…rd_discovery

…oxy payments

…s field

…efault feature to v2

Narayanbhat166 · 2025-02-13T07:16:02Z

crates/api_models/src/payments.rs

@@ -5272,6 +5299,73 @@ pub struct PaymentsConfirmIntentResponse {
    pub error: Option<ErrorDetails>,
 }

+#[cfg(feature = "v2")]
+#[derive(Debug, serde::Serialize, ToSchema)]
+pub struct ProxyPaymentsIntentResponse {


can we use payments response here instead of creating a new response?

applied_authentication_type this is a required field in confirmIntentResponse and is not relevant to proxyResponse

Yes still, let's use the same response, if there are any changes make those fields optional

crates/diesel_models/src/types.rs

Narayanbhat166 · 2025-02-17T07:57:46Z

crates/hyperswitch_domain_models/src/payments.rs

@@ -591,6 +627,7 @@ where
    pub payment_attempt: PaymentAttempt,
    pub payment_method_data: Option<payment_method_data::PaymentMethodData>,
    pub payment_address: payment_address::PaymentAddress,
+    pub mandate_data: Option<api_models::payments::MandateIds>,


we should not be using types from the api models here
cc: @Aprabhat19

should i create this MandateIDs in hyperswitch_domain_model because it is not present there

Yes please, create a struct in domain models for this.

Narayanbhat166 · 2025-02-17T07:59:53Z

crates/diesel_models/src/payment_intent.rs

@@ -215,11 +215,14 @@ impl TaxDetails {
    /// Get the tax amount
    /// If default tax is present, return the default tax amount
    /// If default tax is not present, return the tax amount based on the payment method if it matches the provided payment method type
-    pub fn get_tax_amount(&self, payment_method: PaymentMethodType) -> Option<MinorUnit> {
+    pub fn get_tax_amount(&self, payment_method: Option<PaymentMethodType>) -> Option<MinorUnit> {


change the field name to payment_method_type

there is a subfield in PaymentMethodType with same name of payment_method_type and this subfield is also being used in this function

crates/api_models/src/payments.rs

Narayanbhat166 · 2025-02-17T08:13:29Z

crates/hyperswitch_domain_models/src/payments/payment_attempt.rs

+            customer_acceptance: None,
+            profile_id: payment_intent.profile_id.clone(),
+            organization_id: payment_intent.organization_id.clone(),
+            payment_method_type: storage_enums::PaymentMethod::Card,


we cannot set this value as card, set this to Mandate
cc: @Aprabhat19

bro for our use case we are not dealing anything other than cards for so, i will create another pr for generic use case because it requires a lot of changes in the codebase

Narayanbhat166 · 2025-02-17T08:14:00Z

crates/hyperswitch_domain_models/src/payments/payment_attempt.rs

+            payment_method_type: storage_enums::PaymentMethod::Card,
+            payment_method_id: None,
+            connector_payment_id: None,
+            payment_method_subtype: storage_enums::PaymentMethodType::Credit,


same here, use mandate / connector_token variant
cc: @Aprabhat19

crates/hyperswitch_domain_models/src/payments/payment_intent.rs

crates/router/src/routes/payments.rs

Nishanth Challa and others added 12 commits February 3, 2025 22:45

add revenue_rcovery_metadata to payment intent in diesel and api model

c088d28

chore: run formatter

9ddd2d7

remove unncessary imports

76ccac4

refactor structs of Feature Metadata

f3338d8

refactor(router) : add revenue_recovery_metadata to feature_metadata …

c846fab

…in payment intent for v2 flow

chore: run formatter

a0759eb

add v2 version of proxy_payments function

db0ebaf

correct the construct_router_data and update_trackers

d34f32f

add proxy-confirm-intent api

c9ff63e

change paymentAttemptNew and paymentConfirmData struct

684b5e7

remove all the warnings

f3e12bc

up to date my branch with main

42d67e2

AdityaKumaar21 requested review from a team as code owners February 7, 2025 11:10

AdityaKumaar21 requested a review from Narayanbhat166 February 7, 2025 11:12

Merge branch 'main' into proxyAPIs

e0eedec

AdityaKumaar21 requested a review from SanchithHegde February 7, 2025 11:29

hyperswitch-bot bot and others added 3 commits February 7, 2025 12:23

chore: run formatter

1ae403f

update PaymentAttempt structure to use connector_token_details and ca…

81c3cb5

…rd_discovery

Merge branch 'main' into proxyAPIs

5aae46b

AdityaKumaar21 self-assigned this Feb 12, 2025

hyperswitch-bot bot and others added 5 commits February 12, 2025 09:34

chore: run formatter

1345b0b

add feature_metadata to PaymentIntentUpdate and update handling in pr…

fe61e7d

…oxy payments

chore: run formatter

40b7b36

Merge branch 'main' into proxyAPIs

db079f2

docs(openapi): re-generate OpenAPI specification

f53ecd5

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Feb 13, 2025

update PaymentAttempt to handle authentication type and adjust charge…

0bf7d6b

…s field

hyperswitch-bot bot and others added 5 commits February 13, 2025 19:05

chore: run formatter

155fc9c

pass ci_checks

1d20405

Merge branch 'main' into proxyAPIs

0eb0053

Merge branch 'main' into proxyAPIs

c3bba5f

refactor(payments): update revenue recovery metadata references and d…

f671019

…efault feature to v2

hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Feb 16, 2025

AdityaKumaar21 and others added 4 commits February 17, 2025 01:57

Merge branch 'main' into proxyAPIs

dfbe3df

chore: run formatter

90f5cda

refactor(router): change default feature from v2 to v1

ff0e36e

ci checks pass

bcb3aa0

Narayanbhat166 reviewed Feb 17, 2025

View reviewed changes

resolve comments and update the branch

34e675f

AdityaKumaar21 requested review from a team as code owners February 24, 2025 17:47

AdityaKumaar21 and others added 3 commits February 24, 2025 23:25

Merge branch 'main' into proxyAPIs

093d2af

chore: run formatter

fd2958a

Merge branch 'main' into proxyAPIs

5ca3d40

Narayanbhat166 removed request for a team February 25, 2025 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(router): add proxy-confirm-intent api for payments in v2 flow #7215

feat(router): add proxy-confirm-intent api for payments in v2 flow #7215

AdityaKumaar21 commented Feb 7, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 7, 2025 •

edited

Loading

Narayanbhat166 Feb 13, 2025

AdityaKumaar21 Feb 25, 2025

Narayanbhat166 Feb 25, 2025

Narayanbhat166 Feb 17, 2025

AdityaKumaar21 Feb 24, 2025

Narayanbhat166 Feb 25, 2025

Narayanbhat166 Feb 17, 2025

AdityaKumaar21 Feb 24, 2025

Narayanbhat166 Feb 17, 2025

AdityaKumaar21 Feb 24, 2025 •

edited

Loading

Narayanbhat166 Feb 17, 2025

feat(router): add proxy-confirm-intent api for payments in v2 flow #7215

Are you sure you want to change the base?

feat(router): add proxy-confirm-intent api for payments in v2 flow #7215

Conversation

AdityaKumaar21 commented Feb 7, 2025 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdityaKumaar21 Feb 24, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdityaKumaar21 commented Feb 7, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 7, 2025 •

edited

Loading

AdityaKumaar21 Feb 24, 2025 •

edited

Loading