fix(analytics): retry implementation for forex crate call #7280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
2 tasks
ShivanshMathurJuspay
changed the title
ShivanshMathurJuspay
changed the title
ShivanshMathurJuspay
changed the title
Chethan-rao
requested changes
Feb 17, 2025
crates/router/src/core/currency.rs
Outdated
Comment on lines
64
to
72
| Err(error) => { | ||
| if attempt >= max_attempts { | ||
| logger::error!("Failed to fetch forex rates after {max_attempts} attempts"); | ||
| return Err(error.change_context(AnalyticsError::ForexFetchFailed)); | ||
| } | ||
| logger::warn!("Forex rates fetch failed, retrying in {attempt} seconds"); | ||
| tokio::time::sleep(std::time::Duration::from_secs(attempt)).await; | ||
| attempt += 1; | ||
| } |
There was a problem hiding this comment.
Instead of retrying on all error cases, should we match on the error type and retry only if its a retryable error? Something like failing to attain redis lock could be retried but incorrect forex creds error cannot be
There was a problem hiding this comment.
Redis lock is not there now on the function which we are invoking
sahkal
reviewed
Feb 17, 2025
crates/router/src/core/currency.rs
Outdated
| let rates = get_forex_rates(&state, forex_api.call_delay) | ||
| .await | ||
| .change_context(AnalyticsError::ForexFetchFailed)?; | ||
| let max_attempts = 3; |
There was a problem hiding this comment.
should this max_attempt be hard coded or should this be a config option, if hardcoded can we maintain in the consts.rs
… into forex_analytics_retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implementing a retry logic for forex crate call with linear time increment in retry counter
Additional Changes
crates/router/src/core/currency.rsMotivation and Context
This was required as the Analytics API was returning 5xx when forex was returning error which would eventually resolve on retry
How did you test it?
Added logs for the same
Checklist
cargo +nightly fmt --allcargo clippy