-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments): [Payment links] add configs for payment link #7340
Open
cookieg13
wants to merge
3
commits into
main
Choose a base branch
from
payment-link-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
07510a0
to
2f3f996
Compare
kashif-m
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revert the field back to payment_button_colour
as it's already being used.
crates/router/src/core/payment_link/payment_link_initiate/payment_link.js
Outdated
Show resolved
Hide resolved
e23d6a1
to
2c3a288
Compare
2c3a288
to
18f4698
Compare
kashif-m
previously approved these changes
Feb 25, 2025
SanchithHegde
previously approved these changes
Feb 25, 2025
Ideal behavior of a payment link is to have status page display, whereas this PR does the opposite. Can we have discussion regarding this before moving forward |
4049e04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
display_status_screen
in payment links to decide whether to show status screen after payment completionbackground_color
to customize background color for payment linkspayment_button_text_color
to customize text color for payment button in payment linkAdditional Changes
Motivation and Context
How did you test it?
Tested locally
Update business_profile configs (with
display_status_screen
as true)Create payment link
Payment link
Screen.Recording.2025-02-21.at.14.07.49.mov
Update business_profile configs (with
display_status_screen
as false)Create payment link
Payment link
Screen.Recording.2025-02-21.at.14.08.20.mov
Update business_profile configs (with
background_color
,payment_button_text_color
)Create payment link
Payment link

Checklist
cargo +nightly fmt --all
cargo clippy