Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify metadata object for html content #205

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

quartusk
Copy link
Contributor

@quartusk quartusk commented Feb 6, 2025

When the optional metadata object is passed, the object was never converted to a string representation, which results in the html content using the default serialization and looking like this:

metadata: [object Object]

After applying JSON.stringify to the object, we'll get a valid string representation:

metadata: {"custom_fields":[{"display_name":"Test Custom Field","variable_name":"test_custom_field","value":"Test Value"}]},

@just1and0
Copy link
Owner

just1and0 commented Feb 6, 2025

Hi @quartusk good spot! I will approve once it passes CI checks.

I would also recommend you read the contribution docs to better understand how to name your commits.

This is important as CI will not publish your changes to npm if this isn't done right.

@quartusk
Copy link
Contributor Author

quartusk commented Feb 6, 2025

Sorry I missed the CONTRIBUTING.md at first glance. I can create a new pull request if that helps speed things up

@just1and0
Copy link
Owner

Nah you don't need a new pr
You can make an empty space and commit that. But make sure it's the right commit title.

And that should do it

@quartusk
Copy link
Contributor Author

quartusk commented Feb 6, 2025

Thanks, I've amended the commit message

@just1and0 just1and0 self-requested a review February 6, 2025 09:21
@just1and0 just1and0 merged commit 5c35cc9 into just1and0:main Feb 6, 2025
1 check passed
@just1and0
Copy link
Owner

@all-contributors add @quartusk for code

Copy link
Contributor

@just1and0

I've put up a pull request to add @quartusk! 🎉

Copy link

github-actions bot commented Feb 6, 2025

🎉 This PR is included in version 4.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@quartusk quartusk deleted the dev branch February 6, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants