Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-2616 add the code section of the thumbnail component #2204

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Feb 10, 2025

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 – @ashleynolan

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @fernandofranca

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Sorry, something went wrong.

@raoufswe raoufswe requested review from a team as code owners February 10, 2025 21:47
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: a895714

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-thumbnail Patch
pie-docs Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe marked this pull request as draft February 10, 2025 21:47
@raoufswe raoufswe self-assigned this Feb 10, 2025
@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-overview-docs branch from 778241f to 0c029ed Compare February 18, 2025 13:51
@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-code-docs branch from 9e3f994 to 9abd9ad Compare February 18, 2025 14:16
@raoufswe raoufswe marked this pull request as ready for review February 18, 2025 15:50
ashleynolan
ashleynolan previously approved these changes Feb 19, 2025
@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-overview-docs branch from eddb5eb to d5e14f0 Compare February 20, 2025 14:46
Base automatically changed from dsw-2616-thumbnail-overview-docs to main February 24, 2025 15:05
@raoufswe raoufswe dismissed ashleynolan’s stale review February 24, 2025 15:05

The base branch was changed.

@raoufswe raoufswe force-pushed the dsw-2616-thumbnail-code-docs branch from 4321a7f to 778be9b Compare February 24, 2025 15:08
fernandofranca
fernandofranca previously approved these changes Feb 24, 2025
@raoufswe raoufswe requested a review from ashleynolan February 24, 2025 15:21
@raoufswe raoufswe merged commit 3c85d23 into main Feb 24, 2025
29 checks passed
@raoufswe raoufswe deleted the dsw-2616-thumbnail-code-docs branch February 24, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants