Skip to content

chore(pie-monorepo): DSW-4032 update deps#2913

Merged
siggerzz merged 13 commits into
mainfrom
dsw-4032-update-yo
Jun 5, 2026
Merged

chore(pie-monorepo): DSW-4032 update deps#2913
siggerzz merged 13 commits into
mainfrom
dsw-4032-update-yo

Conversation

@siggerzz

@siggerzz siggerzz commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Describe your changes (can list changeset entries if preferable)

  • Updates deps
  • Removes deps
  • Replaces unmaintained deps

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

@siggerzz siggerzz requested a review from a team as a code owner June 4, 2026 14:30
@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 58f0d48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@justeattakeaway/stylelint-no-logical-props-shorthands Patch
@justeattakeaway/eslint-plugin-snacks-pie-migration Patch
@justeattakeaway/generator-pie-component Patch
@justeattakeaway/eslint-config-pie Patch
@justeattakeaway/pie-icons-webc Patch
@justeattakeaway/pie-icons Patch
@justeattakeaway/pie-css Patch
@justeattakeaway/pie-storybook Patch
@justeattakeaway/pie-monorepo-utils Patch
@justeattakeaway/stylelint-config-pie Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-assistive-text Patch
@justeattakeaway/pie-avatar Patch
@justeattakeaway/pie-breadcrumb Patch
@justeattakeaway/pie-chip Patch
@justeattakeaway/pie-icon-button Patch
@justeattakeaway/pie-link Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-notification Patch
@justeattakeaway/pie-switch Patch
@justeattakeaway/pie-text-input Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-checkbox-group Patch
@justeattakeaway/pie-checkbox Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-radio-group Patch
@justeattakeaway/pie-select Patch
@justeattakeaway/pie-textarea Patch
@justeattakeaway/pie-toast-provider Patch
@justeattakeaway/pie-webc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread apps/pie-storybook/package.json
Comment thread packages/tools/eslint-plugin-snacks-pie-migration/package.json
Comment thread packages/tools/eslint-plugin-snacks-pie-migration/package.json
Comment thread packages/tools/generator-pie-component/package.json
Comment thread packages/tools/pie-css/package.json
Comment thread packages/tools/pie-icons-webc/package.json
Comment thread packages/tools/pie-icons-webc/package.json
Comment thread package.json
@siggerzz siggerzz changed the title Dsw 4032 update yo chore(pie-monorepo): DSW-4032 update deps Jun 4, 2026
@siggerzz siggerzz requested a review from Copilot June 4, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates and rationalizes dependencies across the PIE monorepo tooling packages, adjusts a few scripts/docs to match the new dependency strategy, and tweaks CI to avoid an unstable Windows Node 24 build.

Changes:

  • Updates/removes/replaces various tool dependencies (e.g. glob/rimraf, generator + lint tooling, dompurify).
  • Standardises some script invocations (e.g. moving some builds from ts-node to tsx, and vitest run via run -T).
  • Disables the Windows Node 24 CI build job (commented out) and removes it from the required job list.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/tools/pie-icons/package.json Removes glob from devDeps while icon sync scripts still import it.
packages/tools/pie-icons-webc/package.json Removes unused dev tooling deps (e.g. @web/test-runner, rimraf).
packages/tools/pie-css/package.json Updates build scripts to use tsx instead of ts-node.
packages/tools/generator-pie-component/README.md Updates generator usage instructions to account for yo changes.
packages/tools/generator-pie-component/package.json Updates generator dependencies (Yeoman + related packages).
packages/tools/eslint-plugin-snacks-pie-migration/package.json Adjusts test scripts and removes glob from devDeps.
packages/tools/eslint-config-pie/package.json Standardises test script invocation via run -T vitest run.
package.json Bumps root tooling deps (glob/rimraf/sass/turbo/etc), adds resolutions, switches some internal deps to workspace:*, removes yo.
apps/pie-storybook/package.json Updates dompurify, removes serve.
.github/workflows/ci.yml Disables the Windows Node 24 build and updates job wiring/formatting.
.changeset/few-apes-roll.md Adds a changeset covering the affected packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tools/pie-icons/package.json
Comment thread packages/tools/eslint-plugin-snacks-pie-migration/package.json
Comment thread packages/tools/generator-pie-component/README.md Outdated
jamieomaguire
jamieomaguire previously approved these changes Jun 4, 2026
Comment thread packages/tools/generator-pie-component/README.md Outdated
fernandofranca
fernandofranca previously approved these changes Jun 4, 2026

@fernandofranca fernandofranca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!
One minor comment.

@siggerzz siggerzz dismissed stale reviews from fernandofranca and jamieomaguire via 6f0d016 June 4, 2026 15:19
@siggerzz

siggerzz commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

siggerzz and others added 12 commits June 5, 2026 10:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- declare glob explicitly: dependency in eslint-plugin-snacks-pie-migration
  (consumed at runtime via the ./extract-component-data export) and
  devDependency in pie-icons (used only by unshipped bin scripts)
- fix generator README: use `yo` directly instead of `yarn yo` now that
  yo is installed globally rather than as a repo dependency
- fix changeset-snapshot for execa v9: execa.command was removed in v9,
  use execaCommand instead (fixes /test-aperture snapshot release)
- declare execa as an explicit devDependency on pie-monorepo-utils so the
  changeset-snapshot workflow no longer relies on a transitive copy whose
  major version can change (yeoman-generator bump silently moved it 8->9)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changesets/cli 2.31.0 (PR #1889) errors on unsupported flags per command.
`changeset publish` only accepts --tag/--otp/--git-tag, so:
- `--no-git-tags` -> `--no-git-tag` (singular; maps to gitTag: false)
- drop `--snapshot` (a `version` flag, already applied via changeset:snapshot)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@siggerzz siggerzz force-pushed the dsw-4032-update-yo branch from 1b4ab1d to 58f0d48 Compare June 5, 2026 09:24
@siggerzz

siggerzz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app

Copy link
Copy Markdown
Contributor

@siggerzz Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-assistive-text@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-avatar@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-breadcrumb@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-checkbox@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-checkbox-group@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-chip@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-icon-button@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-link@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-modal@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-notification@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-radio-group@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-select@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-switch@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-text-input@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/eslint-config-pie@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/generator-pie-component@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-css@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-icons@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/pie-icons-webc@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/stylelint-config-pie@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile
yarn up @justeattakeaway/stylelint-no-logical-props-shorthands@0.0.0-snapshot-release-20260605093403 --mode=update-lockfile

Then finally:

yarn install

@siggerzz siggerzz merged commit de178ad into main Jun 5, 2026
220 of 232 checks passed
@siggerzz siggerzz deleted the dsw-4032-update-yo branch June 5, 2026 12:43
@pie-design-system-app pie-design-system-app Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants