chore(pie-monorepo): DSW-4032 update deps#2913
Conversation
🦋 Changeset detectedLatest commit: 58f0d48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR updates and rationalizes dependencies across the PIE monorepo tooling packages, adjusts a few scripts/docs to match the new dependency strategy, and tweaks CI to avoid an unstable Windows Node 24 build.
Changes:
- Updates/removes/replaces various tool dependencies (e.g. glob/rimraf, generator + lint tooling, dompurify).
- Standardises some script invocations (e.g. moving some builds from
ts-nodetotsx, andvitest runviarun -T). - Disables the Windows Node 24 CI build job (commented out) and removes it from the required job list.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tools/pie-icons/package.json | Removes glob from devDeps while icon sync scripts still import it. |
| packages/tools/pie-icons-webc/package.json | Removes unused dev tooling deps (e.g. @web/test-runner, rimraf). |
| packages/tools/pie-css/package.json | Updates build scripts to use tsx instead of ts-node. |
| packages/tools/generator-pie-component/README.md | Updates generator usage instructions to account for yo changes. |
| packages/tools/generator-pie-component/package.json | Updates generator dependencies (Yeoman + related packages). |
| packages/tools/eslint-plugin-snacks-pie-migration/package.json | Adjusts test scripts and removes glob from devDeps. |
| packages/tools/eslint-config-pie/package.json | Standardises test script invocation via run -T vitest run. |
| package.json | Bumps root tooling deps (glob/rimraf/sass/turbo/etc), adds resolutions, switches some internal deps to workspace:*, removes yo. |
| apps/pie-storybook/package.json | Updates dompurify, removes serve. |
| .github/workflows/ci.yml | Disables the Windows Node 24 build and updates job wiring/formatting. |
| .changeset/few-apes-roll.md | Adds a changeset covering the affected packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fernandofranca
left a comment
There was a problem hiding this comment.
Great stuff!
One minor comment.
6f0d016
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- declare glob explicitly: dependency in eslint-plugin-snacks-pie-migration (consumed at runtime via the ./extract-component-data export) and devDependency in pie-icons (used only by unshipped bin scripts) - fix generator README: use `yo` directly instead of `yarn yo` now that yo is installed globally rather than as a repo dependency - fix changeset-snapshot for execa v9: execa.command was removed in v9, use execaCommand instead (fixes /test-aperture snapshot release) - declare execa as an explicit devDependency on pie-monorepo-utils so the changeset-snapshot workflow no longer relies on a transitive copy whose major version can change (yeoman-generator bump silently moved it 8->9) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changesets/cli 2.31.0 (PR #1889) errors on unsupported flags per command. `changeset publish` only accepts --tag/--otp/--git-tag, so: - `--no-git-tags` -> `--no-git-tag` (singular; maps to gitTag: false) - drop `--snapshot` (a `version` flag, already applied via changeset:snapshot) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1b4ab1d to
58f0d48
Compare
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
@siggerzz Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-assistive-text@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-avatar@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-breadcrumb@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-checkbox@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-checkbox-group@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-chip@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-icon-button@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-link@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-modal@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-notification@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-radio-group@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-select@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-switch@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-text-input@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-toast@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/eslint-config-pie@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/eslint-plugin-snacks-pie-migration@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/generator-pie-component@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-css@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-icons@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/pie-icons-webc@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/stylelint-config-pie@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileyarn up @justeattakeaway/stylelint-no-logical-props-shorthands@0.0.0-snapshot-release-20260605093403 --mode=update-lockfileThen finally: yarn install |
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.