fix(parsers): merge dict tool_input fragments instead of concatenating#225
Open
LazarusX wants to merge 1 commit into
Open
fix(parsers): merge dict tool_input fragments instead of concatenating#225LazarusX wants to merge 1 commit into
LazarusX wants to merge 1 commit into
Conversation
When the Kiro API sends tool arguments split across multiple tool_input
events as dicts, the parser was serializing each dict independently and
concatenating the JSON strings — producing invalid JSON like
`{"file_path":"..."}{"content":"..."}`. The brace-counting diagnostic
then misidentified this as upstream truncation.
Fix: accumulate dict fragments via .update() and serialize once at
finalize time. String fragment path remains unchanged.
Fixes jwadow#153
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for the PR! 🎉 Before merge, we need a one-time CLA confirmation. Full CLA text: Please reply once with: You need to write once, all further messages from me can be ignored. |
Author
|
I have read the CLA and I accept its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Writetool calls with large contenttool_inputevents as dicts, the parser serialized each dict independently and concatenated the JSON strings — producing invalid JSON like{"file_path":"..."}{"content":"..."}.update()and serializes once at finalize timeTest plan
Writetool call with JSON-like patterns in content succeeds without truncation errorFixes #153
🤖 Generated with Claude Code