Random stuff #178
Merged
Random stuff #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several letters were used twice or more by various options---the old code assumes that no roles start with the same letter and that now races/alignments/genders start with the same letter, and between caveperson/convict and a whole bunch of races this is no longer true. Hardcode the stuff instead. If lots more races/roles are plans, perhaps this stuff should be made a field in the race/role constructs, but for now this suffices.
This makes intuitive sense and means we don't have to worry about where to put the steed---win-win!
It used to be (like in vanilla 3.3 or something) WHACK/PIERCE/SLASH were defined as 0/1/2. The damage type for weptools was used as their to-hit bonus. But, when WHACK was redefined as 4, the to-hit bonuses changed, too. Pretty sure this is still extant in vanilla as well, just less noticeable because vanilla has no object lookup.
When zombies die, their corpses are transformed into default racial corpses, e.g. orc zombie->orc. This meant that you could only do same-race sacrifice as a draugr by chancing upon a draugr NPC or wishing explicitly for a 'foo zombie corpse.' This allows corpses left by zombies to be used as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of various bugfixes for review.