Add information in debugging in k3po.js, added some extra logging in …

…the browser for when debugging was enabled
k3po · Jan 13, 2016 · 170693c · 170693c
1 parent 2c51000
commit 170693c
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 6 deletions.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -75,7 +75,9 @@ module.exports = function (grunt) {
                     ui: 'mocha-k3po',
                     require: 'lib/testFrameworks/mocha-k3po.js',
                     captureFile: "build/testMochaK3po.txt",
+                    // timeout: 5000,
                     browser: {
+                        // debug: true,
                         desiredCapabilities: {
                             browserName: 'firefox'
                         }

diff --git a/README.md b/README.md
@@ -127,3 +127,19 @@ Configuration via Grunt
 
 1. `npm install`
 1. `grunt`
+
+### Debugging the browser
+
+By default the browser closes after the test, in case of test failures you can pass the debug flag to the browser
+configuration as shown to keep it open.  This allows access to the browser javascript console.
+
+```JavaScript
+browser: {
+    desiredCapabilities: {
+        browserName: 'firefox'
+    },
+    debug: true
+}
+
+```
+
diff --git a/lib/browser/BrowserRunner.js b/lib/browser/BrowserRunner.js
@@ -37,9 +37,9 @@ BrowserRunner.prototype.loadOrigin = function () {
         _this._browser.url(this._origin);
     }
 
-    return _this._browser.execute(RemoteScriptRunner).execute(function (resources) {
-        k3po = new RemoteScriptRunner(resources);
-    }, _this._resources).then();
+    return _this._browser.execute(RemoteScriptRunner).execute(function (resources, debug) {
+        k3po = new RemoteScriptRunner(resources, debug);
+    }, _this._resources, _this._debug).then();
 };
 
 BrowserRunner.prototype.getExceptions = function () {

diff --git a/lib/browser/RemoteScriptRunner.js b/lib/browser/RemoteScriptRunner.js
@@ -13,11 +13,12 @@ var window;
  */
 module.exports = function () {
 
-    RemoteScriptRunner = function RemoteScriptRunner(resources) {
+    RemoteScriptRunner = function RemoteScriptRunner(resources, debug) {
         this._state = "INITIAL";
         this._cmdQueue = [];
         this._eventListenerMap = [];
         this._eventAlreadyFiredEventMap = [];
+        this._debug = debug;
         for (var i = 0; i < resources.length; i++) {
             this.loadScript(resources[i]);
         }
@@ -138,7 +139,11 @@ module.exports = function () {
 
     RemoteScriptRunner.prototype.nextCommand = function () {
         if (this._cmdQueue.length > 0) {
-            return this._cmdQueue.shift();
+            var command = this._cmdQueue.shift();
+            if(this._debug) {
+                console.log("RemoteScriptRunner received command: " + command);
+            }
+            return command;
         }
         return null;
     };
@@ -153,6 +158,9 @@ module.exports = function () {
         var arg = null;
         var type = event.type;
 
+        if(this._debug) {
+            console.log("RemoteScriptRunner fired event: " + type);
+        }
         switch (type) {
             case "NOTIFIED":
                 arg = event.barrier;

diff --git a/test/testFrameworks/mocha-k3po_spec.js b/test/testFrameworks/mocha-k3po_spec.js
@@ -20,10 +20,10 @@ describe('WsClient', function () {
         ws.onmessage = function (event) {
             chai.assert.equal(event.data, echoText);
             ws.close();
+            done();
         };
 
         ws.onclose = ws.onerror = function () {
-            done();
         };
     });