Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hardcoded k8sgpt image respository #272

Merged
merged 4 commits into from
Nov 27, 2023
Merged

remove hardcoded k8sgpt image respository #272

merged 4 commits into from
Nov 27, 2023

Conversation

JuHyung-Son
Copy link
Contributor

@JuHyung-Son JuHyung-Son commented Nov 21, 2023 •
edited
Loading

Closes #268

📑 Description

  • add image repository in k8sgpt crd.
  • remove hardcoded image repository.
  • controller reconcile repository not just version

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@JuHyung-Son JuHyung-Son requested review from a team as code owners November 21, 2023 15:47
arbreezy
arbreezy reviewed Nov 26, 2023
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, but please also update the helm chart's CRD template, unfortunately we haven't built yet an automation to update chart's CRD when you modify the K8sGPT spec.

@JuHyung-Son
Copy link
Contributor Author

@arbreezy i update charts/templates/k8sgpt.

@arbreezy arbreezy merged commit 7d91f37 into k8sgpt-ai:main Nov 27, 2023
6 checks passed
@JuHyung-Son JuHyung-Son deleted the feat/k8sgpt-image branch November 28, 2023 02:12
@JuHyung-Son JuHyung-Son mentioned this pull request Dec 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbreezy arbreezy arbreezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: add k8sgpt image in operator k8sgpt crd
2 participants
@JuHyung-Son @arbreezy