Issue 280 #282
Merged
Issue 280 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuHyung-Son
force-pushed
the
issue-280
branch
from
baa7123 to
263e4ba
Compare
AlexsJones
previously approved these changes
Dec 6, 2023
|
Thanks @JuHyung-Son ! Can you please resolve conflicts? |
|
i just did it thanks |
2 tasks
|
@AlexsJones would you review this? |
AlexsJones
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Sorry for the delay @JuHyung-Son please make pullsecrets optional - we could have it as a single example in the README also e.g.
<details>
<summary>Pull secrets</summary>
...
</details>
AlexsJones
reviewed
Dec 21, 2023
README.md
Outdated
| @@ -50,6 +50,8 @@ spec: | |||
| noCache: false | |||
| repository: ghcr.io/k8sgpt-ai/k8sgpt | |||
| version: v0.3.8 | |||
| imagePullSecrets: | |||
There was a problem hiding this comment.
Not everyone will use pull secrets, even if they do can you put a more generic secret name e.g. mysecret ? we only need an example of this in the full example of the k8sgpt CR
There was a problem hiding this comment.
you are right. i add k8sgpt configuration option
JuHyung-Son
force-pushed
the
issue-280
branch
from
d9dec62 to
8b38b55
Compare
AlexsJones
approved these changes
Dec 21, 2023
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
JuHyung-Son
force-pushed
the
issue-280
branch
from
8b38b55 to
595d972
Compare
|
@AlexsJones i resolved DCO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280
📑 Description
add imagePullSecrets to k8sgpt spec.
if given, imagePullSecrets will be added to
k8sgptserviceaccounts✅ Checks
ℹ Additional Information
i couldn't test it on my local environment. please test it works well. i will ask how to set local dev environment in slack.