Fix panics when running tests in actions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, |
nocturnalastro
force-pushed
the
test_panic
branch
3 times, most recently
from
5858be6 to
54fa639
Compare
nocturnalastro
changed the title
nocturnalastro
force-pushed
the
test_panic
branch
2 times, most recently
from
5b5eaa8 to
e359637
Compare
Sleep allows go routine context to switch allowing the close side effect to happen before function exits
nocturnalastro
force-pushed
the
test_panic
branch
from
e359637 to
732e2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by adding sleep allows go routine context to switch allowing the close side effect to happen before function exits