Make advertising of NUMA node optional #416
Merged
+80
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthakur-est
force-pushed
the
exclude_numa
branch
2 times, most recently
from
ab5f250 to
90dcac9
Compare
This change adds support for making advertising of NUMA node optional. This can be done per resource pool by setting the config "exclude_topology" to true. Default behavior is to advertise NUMA node information. Signed-off-by: Ravindra Thakur <[email protected]>
rthakur-est
force-pushed
the
exclude_numa
branch
from
90dcac9 to
ed04ec5
Compare
|
Looks good to me. Thank you @rthakur-est |
|
LGTM |
Eoghan1232
approved these changes
Apr 5, 2022
|
when will this be merged? |
e0ne
reviewed
Apr 19, 2022
e0ne
approved these changes
Apr 19, 2022
|
LGTM, need to update README with new resource config knob. this can be done in this PR or a separate one as discussed in Yesterday's community meeting. |
adrianchiris
approved these changes
Apr 20, 2022
SchSeba
reviewed
Apr 26, 2022
My colleague @rthakur-est is on leave. He will push another review updating the README soon. This review can be merged if its good. |
|
@SchSeba do you have additional comments ? shall we proceed with merge ? |
|
raised PR for documentation - #425 |
SchSeba
approved these changes
May 10, 2022
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for making advertising of NUMA node optional.
This can be done per resource pool by setting the config
"exclude_topology" to true. Default behavior is to advertise NUMA node
information.
#320
Signed-off-by: Ravindra Thakur [email protected]