Make K8SeedProvider Kubernetes aware #240
Open
+52
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kubernetes version is 1.21 or newer
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Contributor
Author
|
Ah, the integration test doesn't have running Kubernetes, so this will fail to instantiate the connection. Hmm.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just trying to resolve hostnames, do actually treat the seed addresses as real target services. Use kubernetes-client to fetch EndpointSlices for the known seeds if Kubernetes version is 1.21 or newer.
This should also solve the issue with incorrect logging of not being able to resolve additional-seeds.