Merge pull request #29 from triptease/overlapping-styles

fix overlapping styles bug

src/draftjsToMd.js

@@ -97,6 +97,10 @@ function fixWhitespacesInsideStyle(text, style) {
       `${prefix}${symbol}${bodyTrimmed}${symbol}${postfix}`);
 }
 
+function getInlineStyleRangesByLength(inlineStyleRanges) {
+  return [...inlineStyleRanges].sort((a, b) => b.length - a.length);
+}
+
 function draftjsToMd(raw, extraMarkdownDict) {
   const markdownDict = { ...defaultMarkdownDict, ...extraMarkdownDict };
   let returnString = '';
@@ -119,8 +123,10 @@ function draftjsToMd(raw, extraMarkdownDict) {
     returnString += block.text.split('').reduce((text, currentChar, index) => {
       let newText = text;
 
+      const sortedInlineStyleRanges = getInlineStyleRangesByLength(block.inlineStyleRanges);
+
       // find all styled at this character
-      const stylesStartAtChar = block.inlineStyleRanges
+      const stylesStartAtChar = sortedInlineStyleRanges
         .filter(range => range.offset === index)
         .filter(range => markdownDict[range.style]); // disregard styles not defined in the md dict
 

test/draftjsToMd.test.js

@@ -122,6 +122,31 @@ describe('draftjsToMd', () => {
     draftjsToMd(raw).should.equal(expectedMarkdown);
   });
 
+  it('converts overlapping styles correctly, whether or not the "longer" one is first', () => {
+    const raw = {
+      blocks: [{
+        text: 'I start with italic bold and end with only bold.',
+        type: 'unstyled',
+        depth: 0,
+        inlineStyleRanges: [
+          {
+            offset: 0,
+            length: 24,
+            style: 'ITALIC'
+          },
+          {
+            offset: 0,
+            length: 48,
+            style: 'BOLD'
+          },
+        ],
+        entityRanges: []
+      }]
+    };
+    const expectedMarkdown = '__*I start with italic bold* and end with only bold.__';
+    draftjsToMd(raw).should.equal(expectedMarkdown);
+  });
+
   it('converts the last word correctly if it is styled', () => {
     const raw = {
       blocks: [{