Maven enabled compilation #4
Conversation
…fixed the problem.
|
Why is all the maven stuff in a separate directory? Why is the install sh script needed. |
|
Maven is in separate directory because i dont want to force anybody to use maven, discussion on what project manager to use is in progress http://groups.google.com/group/kafka-dev/browse_thread/thread/1f2c2f1d5c0d2bea. And instal script is obsolete now. |
|
Putting a POM file in the root directory doesn't force anyone to use maven. Alternatively, putting maven in a separate directory makes it seem overly complicated when it is not. |
|
You're right, i'll put pom.xml into the root directory. No problem. |
|
What does the change to the zkclient library have to do with Maven? |
|
It's dependency that is not hosted in central repository, so maven will install this library into the local repository before compilation. It's version with latest fixes. If you insist on version 0.1.0 i have no problem with that. |
|
Why did you rename the zookeeper jar? |
|
I have not just renamed it i have used newest version of zookeeper. Is it not obvious? |
|
No, it looks like all you did was renamed it. |
|
Well, commit message "Upgrade to ZooKeeper version 3.3.2." is easy to understand i guess. |
|
Yeah, that's the commit message, not necessarily what happened. However, it seems that git hub erroneously states that the file did not change. |
|
I understand, trust no one :) |
|
Any progress in rewieving my patches? |
|
See also this thread: http://groups.google.com/group/kafka-dev/browse_thread/thread/9f0f89a1496d7972 |
|
Hi abelaska, I think at this point sbt's make-pom command produces something reasonable. Do you still think a manually managed pom for compilation is worthwhile? If so could you open a ticket on the new Apache Issue tracker: https://issues.apache.org/jira/browse/KAFKA ? |
|
Hi, Cheers, |
Hi,
i have created simple mavenizing of project, so maven users can also easily use Kafka library.