add support for imagePullSecrets in postgres deployment#1552
Merged
EItanya merged 1 commit intokagent-dev:mainfrom Mar 26, 2026
Merged
add support for imagePullSecrets in postgres deployment#1552EItanya merged 1 commit intokagent-dev:mainfrom
EItanya merged 1 commit intokagent-dev:mainfrom
Conversation
Signed-off-by: Dmitri Dolguikh <dmitri@appliedlogic.ca>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Helm chart support to optionally render imagePullSecrets on the bundled PostgreSQL Deployment, allowing pulls from private registries when configured.
Changes:
- Added a new Helm helper (
kagent.imagePullSecrets) intended to renderimagePullSecrets. - Wired the helper into the PostgreSQL
Deploymentpod spec. - Added helm-unittest assertions for default and configured
imagePullSecretsbehavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
helm/kagent/tests/postgresql_test.yaml |
Adds tests asserting whether imagePullSecrets is rendered for the PostgreSQL Deployment. |
helm/kagent/templates/postgresql.yaml |
Includes an imagePullSecrets helper in the PostgreSQL pod spec. |
helm/kagent/templates/_helpers.tpl |
Introduces a helper that renders imagePullSecrets (currently sourced from global.imagePullSecrets). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.