Adds queryParams as an option for getAll requests #246
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasprag
reviewed
May 17, 2017
| @@ -1,7 +1,7 @@ | |||
| Package.describe({ | |||
| name: 'nimble:restivus', | |||
| name: 'maka:rest', | |||
There was a problem hiding this comment.
I'm not sure if is a good idea to rename the package.
May you could close this PR and open a new one without those commits? what you think?
| @@ -14,7 +14,7 @@ Package.onUse(function (api) { | |||
| api.use('check'); | |||
| api.use('coffeescript'); | |||
| api.use('underscore'); | |||
| api.use('accounts-password@1.1.4'); | |||
| api.use('accounts-password@1.2.12'); | |||
There was a problem hiding this comment.
Also, I'm not sure if is a good idea to upgrade that package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that queryParams was left out of the getAll request. This will allow query parameters to either be omitted, and thus an empty object will be used (which is how it works now), or this will make a mongodb query with the supplied query params.