kaiax/vrank, blockchain/types: reject present-but-empty VRank and cou…#989
Open
hyunsooda wants to merge 1 commit into
Open
kaiax/vrank, blockchain/types: reject present-but-empty VRank and cou…#989hyunsooda wants to merge 1 commit into
hyunsooda wants to merge 1 commit into
Conversation
…nt it in header size Before the permissionless fork the VRank header field must be absent. The guard checked len(VRank) > 0, but an explicitly encoded empty RLP string decodes to a non-nil zero-length slice: it passes the length check yet is re-encoded as a trailing element, so nodes carrying the field accept the header while nodes without it reject the extra element. Check presence (!= nil) instead. Separately, Header.Size() omitted the VRank payload, undercounting headers that carry it. Add len(h.VRank) to the byte size. Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
len(header.VRank) > 0, but an explicit empty RLPstring decodes to a non-nil zero-length slice — passes the length check yet
re-encodes as a trailing element. Check presence (
!= nil) instead.Header.Size()omitted the VRank payload; addlen(h.VRank).Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments