-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
부산대 Android_이지은 5주차 2단계(리팩토링 완료) #77
Open
JieunYume
wants to merge
22
commits into
kakao-tech-campus-2nd-step2:jieunyume
Choose a base branch
from
JieunYume:jieunyume-step2
base: jieunyume
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bc798bc
docs: update README.md
JieunYume dd8ed1b
feat: Room 플러그인과 라이브러리 추가
JieunYume 1faf7fd
feat: SavedLocation을 위한 entity, dao, room database 구현
JieunYume e12de89
feat: SavedLocationRepository에서 SavedLocationDataSource가 아닌 addDataba…
JieunYume a02a8cf
refactor: data source 클래스들의 이름 수정, LocationDto를 Location으로 수정하는 코드를 L…
JieunYume b777f09
refactor: 함수명 수정 및 패키지 이동
JieunYume 5c44b53
feat: Hilt 라이브러리 추가 및 App의 종속성 컨테이너 설정
JieunYume 038b4d9
feat: Repository 인터페이스를 사용하도록 수정
JieunYume d904772
refactor: LocationModule을 만들어 의존성 선언
JieunYume b930b26
refactor: SavedLocationModule을 만들어 의존성 선언
JieunYume 5626965
refactor: Repository들을 Binds 방식으로 의존성 선언
JieunYume 3670177
docs: update README.md
JieunYume 7da86f2
refactor: item_location.xml에서 data binding을 사용하도록 수정
JieunYume 4dd446e
refactor: item_saved_location.xml에서 data binding을 사용하도록 수정
JieunYume 7256a0b
refactor: findViewById() 사용를 없애고 view binding을 사용하도록 변경
JieunYume 33f9b92
refactor: SharedPreferences와 KakaoAPI의 의존성 주입 설정
JieunYume 1488a8d
refactor: CoroutineDispatcher 의존성 주입
JieunYume 89154f6
refactor: Location을 Parcelable로 변경
JieunYume 42c2240
refactor: setOnClickListener로 리스너를 설정했던 방식에서 xml에서 data binding으로 리스너…
JieunYume 8c7baf9
fix: 검색창 클리어 버튼을 누르면 꺼지는 현상 고침
JieunYume bedeeb6
refactor: LocationModule을 object로 변경
JieunYume 18fdc10
refactor: listener 함수명 변경
JieunYume File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
app/src/main/java/campus/tech/kakao/map/model/datasource/LocationRemoteDataSource.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoroutineDispatcher 와 같은 abstract class 나 interface 는 다형성을 띄기 때문에 문제가 발생할 수 있어요.
Qualifer annotation 같은 것으로 "어떤 객체인지" 명확하게 보여주는 것이 좋습니다!